← Back to issue list

plugs/slots: match output format read in snapcraft.yaml

View original Github issue

Metadata

Project
snapcraft
Number
#2884
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged to align snap.yaml output with snapcraft.yaml input by restoring 3.8 plugs/slots formatting. This change works around a review-tools bug and ensures syntax consistency. Approved by one reviewer, passed CI, and modified six files.

Suggested action:

No scores available.

Issue body

Snapcraft recently started always writing the long-form of plugs for consistency, where the `interface` attribute is always defined. Unfortunately this seems to have tripped up a bug in review-tools that won't likely be fixed for a while. This commit restores the 3.8 behavior to ensure the output snap.yaml matches the syntax used in the snapcraft.yaml. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to align snap.yaml output with snapcraft.yaml input by restoring 3.8 plugs/slots formatting. This change works around a review-tools bug and ensures syntax consistency. Approved by one reviewer, passed CI, and modified six files.
qwen3.6-35b-a3b-mtp-q6 Merged a fix aligning snap.yaml output with snapcraft.yaml input by restoring v3.8 plugs/slots formatting. This resolves review-tools compatibility issues caused by snapcraft switching to long-form interface definitions.
qwen3.6-35b-a3b-mtp-q6 Merged. Restores snapcraft 3.8 plug and slot output formatting to match snapcraft.yaml syntax, bypassing a review-tools parsing bug for the standardized long-form interface attribute.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3657 meta: support plugs snapcraft merged Merged into snapcraft/7.0 after approval and CI checks. Adds metadata support for plugs, including ContentPlugs. Modifies four files with 117 additions and two deletions, achieving 95.45% diff coverage.
73%
#1581166 unused and potentially confusing support for plugs/slots at a part level in the snapcraft.yaml schema snapcraft (launchpad) closed Removed unused schema support for part-level plugs and slots in snapcraft.yaml. The schema now rejects these definitions, preventing user confusion. Verified and closed.
73%
#3959 meta: fix snap.yaml app slots snapcraft merged Merged a pull request adding missing app slots to snap.yaml. Approved by a reviewer, passed CI checks, and successfully integrated into the repository.
73%
#4097 projects: warn on "global" assign of plugs and slots snapcraft merged Merged into main. Adds a warning for top-level plug and slot assignments in snapcraft.yaml, replacing deprecated global configuration. Approved by reviewer, passed CI, and incorporated a minor wording adjustment prior to merge.
71%