← Back to issue list

plugs/slots: match output format read in snapcraft.yaml

View original Github issue

Metadata

Project
snapcraft
Number
#2884
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2884 (commit 70e7789a7, cjp256) reverted the long-form plug/slot emission from #2840, restoring 3.8 output so snap.yaml matches the syntax used in snapcraft.yaml (no implied `interface`).

Resolution: closed resolved

Reason: The PR was approved and merged into snapcraft as commit 70e7789a7, restoring the Snapcraft 3.8 plug/slot output format so generated snap.yaml mirrors the long form actually read from snapcraft.yaml, avoiding breakage in downstream review tools.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Snapcraft recently started always writing the long-form of plugs for consistency, where the `interface` attribute is always defined. Unfortunately this seems to have tripped up a bug in review-tools that won't likely be fixed for a while. This commit restores the 3.8 behavior to ensure the output snap.yaml matches the syntax used in the snapcraft.yaml. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2884 (commit 70e7789a7, cjp256) reverted the long-form plug/slot emission from #2840, restoring 3.8 output so snap.yaml matches the syntax used in snapcraft.yaml (no implied `interface`).
stealth/space-bunny-alpha — closed resolved Merged PR #2884 (commit 70e7789a7) restored Snapcraft 3.8-style plug and slot output so generated snap.yaml matches the long-form format read from snapcraft.yaml.
qwen/qwen3.6-35b-a3b — — Merged to align snap.yaml output with snapcraft.yaml input by restoring 3.8 plugs/slots formatting. This change works around a review-tools bug and ensures syntax consistency. Approved by one reviewer, passed CI, and modified six files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix aligning snap.yaml output with snapcraft.yaml input by restoring v3.8 plugs/slots formatting. This resolves review-tools compatibility issues caused by snapcraft switching to long-form interface definitions.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2840 (confidence 85%)

    Commit 971424d0c / PR #2840 'plugs/slots: use default interface if none is specified' introduced the always-long-form output that this PR partially reverted.

Related issues

Issue Project State Summary Similarity
#2840 plugs: plugs can have no element snapcraft merged Merged in snapcraft#2840 via commit 971424d0c, fixing null plug and slot definitions to use their names as implicit interfaces instead of crashing.
78%
#1581166 unused and potentially confusing support for plugs/slots at a part level in the snapcraft.yaml schema snapcraft (launchpad) closed Snapcraft 2.9 now rejects plugs and slots declared at the part level via merged PR canonical/snapcraft#514 (6fabd20bc); the fix passed SRU verification.
76%
#369 Swap plugs and slot functionality for interfaces. snapcraft merged Merged PR #369 via commit 0cacfeeb9 (implementation a8bea29d4), swapping plug/slot handling to interfaces across 10 files for LP #1549427.
71%
#3874 meta: fix content plug detection snapcraft merged Merged PR #3874 in commit b962783c1, allowing empty content plug/slot definitions and deferring type validation until snap packaging.
70%