← Back to issue list

meta: fix content plug detection

View original Github issue

Metadata

Project
snapcraft
Number
#3874
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for snap metadata content plug detection that prevents type error failures, allowing empty definitions. Validation occurs during packaging. Approved by a reviewer, passed CI, and merged after branch targeting clarification.

Suggested action:

No scores available.

Issue body

Don't fail on type errors when detecting content plugs and slots, allowing empty definitions. Snap metadata contents are validated at a later point when packaging the snap file. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for snap metadata content plug detection that prevents type error failures, allowing empty definitions. Validation occurs during packaging. Approved by a reviewer, passed CI, and merged after branch targeting clarification.
qwen3.6-35b-a3b-mtp-q6 Merged fix preventing type errors on empty content plug definitions, deferring validation to packaging. Author clarified it targets a newer library linter feature rather than the requested hotfix branch, so it was merged to main.
qwen3.6-35b-a3b-mtp-q6 Merged fix for content plug detection that prevents type errors on empty definitions, deferring validation to snap packaging. Author clarified the change targets a newer library linter feature, resolving branch retargeting discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3657 meta: support plugs snapcraft merged Merged into snapcraft/7.0 after approval and CI checks. Adds metadata support for plugs, including ContentPlugs. Modifies four files with 117 additions and two deletions, achieving 95.45% diff coverage.
75%
#6222 fix: only precreate content plug targets snapcraft merged Merged a fix preventing errors during plug target precreation for specific formats like private plugs. Approved by two reviewers and integrated with 29 additions and 6 deletions across two files, resolving the reported issue.
74%
#2934 meta: fix for missing content slot's 'content' property snapcraft merged Merged fix for missing 'content' property initialization in content slots from snapcraft.yaml. Includes updated tests for explicit content coverage. Approved, passed CI, and achieved 100% diff coverage.
74%
#2754 meta: support the case of a plug without a default provider snapcraft merged Merged after approval and passing CI checks. Adds metadata support for plugs lacking a default provider. Changes span three files with 24 additions and 3 deletions.
70%