← Back to issue list

meta: fix content plug detection

View original Github issue

Metadata

Project
snapcraft
Number
#3874
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3874 in commit b962783c1, allowing empty content plug/slot definitions and deferring type validation until snap packaging.

Resolution: closed resolved

Reason: PR #3874 was merged as commit b962783c1. It prevents premature type errors during content plug and slot detection; full metadata validation occurs later during packaging.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Don't fail on type errors when detecting content plugs and slots, allowing empty definitions. Snap metadata contents are validated at a later point when packaging the snap file. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3874 in commit b962783c1, allowing empty content plug/slot definitions and deferring type validation until snap packaging.
stealth/space-bunny-alpha — closed resolved Merged PR #3874 (commit b962783c1), allowing empty content plug/slot definitions without early type errors; metadata validation is deferred until snap packaging.
qwen/qwen3.6-35b-a3b — — Merged a fix for snap metadata content plug detection that prevents type error failures, allowing empty definitions. Validation occurs during packaging. Approved by a reviewer, passed CI, and merged after branch targeting clarification.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix preventing type errors on empty content plug definitions, deferring validation to packaging. Author clarified it targets a newer library linter feature rather than the requested hotfix branch, so it was merged to main.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2934 meta: fix for missing content slot's 'content' property snapcraft merged Merged PR #2934 fixed content-slot metadata initialization so snapcraft.yaml content is retained, with added unit coverage; landed as commit 4644651c4.
78%
#6222 fix: only precreate content plug targets snapcraft merged Merged #6222 as 333ac0e0b, limiting plug-target precreation to content plugs so plug definitions containing only private: true no longer error.
73%
#3657 meta: support plugs snapcraft merged Merged PR #3657 into snapcraft/7.0 via b28e65257, adding metadata support for plugs and ContentPlugs (implementation 6512b7cdd; CRAFT-816).
73%
#2840 plugs: plugs can have no element snapcraft merged Merged in snapcraft#2840 via commit 971424d0c, fixing null plug and slot definitions to use their names as implicit interfaces instead of crashing.
73%
#3227 meta: fix content slot to set content when using source key snapcraft merged Merged in canonical/snapcraft#3227 (commit 8cdbe2692), fixing content slots to preserve the content value when source is specified and adding unit tests.
71%
#2884 plugs/slots: match output format read in snapcraft.yaml snapcraft merged Merged PR #2884 (commit 70e7789a7, cjp256) reverted the long-form plug/slot emission from #2840, restoring 3.8 output so snap.yaml matches the syntax used in snapcraft.yaml (no implied `interface`).
70%