← Back to issue list

[legacy] meta: include environment in hook wrappers

View original Github issue

Metadata

Project
snapcraft
Number
#2893
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged into legacy, restoring environment variables in hook wrappers; the corresponding master fix also merged via #2897 (bfac28cea).

Resolution: closed resolved

Reason: PR #2893 was approved and merged, fixing LP #1824255 by restoring environment inclusion in legacy hook wrappers. A separate master implementation merged as #2897 in commit bfac28cea.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Snapcraft regressed in how it handled environment for app wrappers and hook wrappers in that is no longer includes it for hooks (only apps). This PR fixes [LP: #1824255](https://bugs.launchpad.net/snapcraft/+bug/1824255) for legacy by adding back the environment inclusion for hooks.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into legacy, restoring environment variables in hook wrappers; the corresponding master fix also merged via #2897 (bfac28cea).
stealth/space-bunny-alpha — closed resolved Merged into snapcraft legacy branch (+53/-9, 2 files) restoring environment inclusion in hook wrappers so hooks match app wrappers, fixing LP: #1824255. Master counterpart merged as #2897 (commit bfac28cea).
stealth/space-bunny-alpha — closed resolved Merged into legacy, restoring environment inclusion in hook wrappers for LP #1824255; the master adaptation also merged as #2897 (bfac28cea).
stealth/space-bunny-alpha — closed resolved Merged into legacy to restore environment variables in hook wrappers, fixing LP #1824255. The corresponding master fix merged as snapcore/snapcraft#2897 in commit bfac28cea.
stealth/space-bunny-alpha — closed resolved Merged into legacy as snapcore/snapcraft#2893, restoring environment variables in hook wrappers and fixing the regression tracked by LP #1824255.
qwen/qwen3.6-35b-a3b — — Merged into legacy to fix a regression excluding environment variables from hook wrappers. Approved by two reviewers and passed CI. Temporarily closed to align with master, then reopened and merged to resolve Launchpad bug #1824255.
qwen3.6-35b-a3b-mtp-q6 — — Merged into legacy to restore environment variables in hook wrappers, fixing LP #1824255. A separate master fix was prepared due to architectural divergence, but this legacy-specific update passed tests and was merged.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#2897 meta: include environment in hook wrappers snapcraft merged Merged in #2897 via commit bfac28cea, restoring environment inclusion in hook wrappers so hook execution matches app wrappers and resolves LP #1824255.
83%