[legacy] meta: include environment in hook wrappers
Metadata
Current evaluation
Merged into legacy to fix a regression excluding environment variables from hook wrappers. Approved by two reviewers and passed CI. Temporarily closed to align with master, then reopened and merged to resolve Launchpad bug #1824255.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Snapcraft regressed in how it handled environment for app wrappers and hook wrappers in that is no longer includes it for hooks (only apps). This PR fixes [LP: #1824255](https://bugs.launchpad.net/snapcraft/+bug/1824255) for legacy by adding back the environment inclusion for hooks.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into legacy to fix a regression excluding environment variables from hook wrappers. Approved by two reviewers and passed CI. Temporarily closed to align with master, then reopened and merged to resolve Launchpad bug #1824255. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into legacy to restore environment variables in hook wrappers, fixing LP #1824255. A separate master fix was prepared due to architectural divergence, but this legacy-specific update passed tests and was merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into the legacy branch to restore environment variable inclusion for hook wrappers, resolving LP #1824255. The change passed tests and was approved. The master branch diverges via command-chain, keeping this fix legacy-specific. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2897 meta: include environment in hook wrappers | snapcraft | merged | Merged a fix restoring environment variable inclusion for Snapcraft hook wrappers, correcting a regression that limited it to apps. Approved, passed CI, and modified three files. Resolves LP #1824255. |