← Back to issue list

meta: include environment in hook wrappers

View original Github issue

Metadata

Project
snapcraft
Number
#2897
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #2897 via commit bfac28cea, restoring environment inclusion in hook wrappers so hook execution matches app wrappers and resolves LP #1824255.

Resolution: closed resolved

Reason: PR #2897 was merged as commit bfac28cea, restoring environment inclusion for hook wrappers and addressing LP #1824255.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Snapcraft regressed in how it handled environment for app wrappers and hook wrappers in that is no longer includes it for hooks (only apps). Add back the environment inclusion for hooks. LP: #1824255 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com> Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #2897 via commit bfac28cea, restoring environment inclusion in hook wrappers so hook execution matches app wrappers and resolves LP #1824255.
stealth/space-bunny-alpha — closed resolved Merged in #2897 (bfac28cea), restoring environment inclusion in hook wrappers to match app wrappers and resolve LP #1824255.
qwen/qwen3.6-35b-a3b — — Merged a fix restoring environment variable inclusion for Snapcraft hook wrappers, correcting a regression that limited it to apps. Approved, passed CI, and modified three files. Resolves LP #1824255.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix restoring environment variable inclusion for Snapcraft hook wrappers, resolving a regression that previously excluded them. Closes LP: #1824255.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2893 [legacy] meta: include environment in hook wrappers snapcraft merged Merged into legacy, restoring environment variables in hook wrappers; the corresponding master fix also merged via #2897 (bfac28cea).
83%