← Back to issue list

meta: move Snap's from_dict() system-username parsing into SystemUser

View original Github issue

Metadata

Project
snapcraft
Number
#2904
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2904 as commit 939eb0eed, moving Snap.from_dict() system-username parsing into SystemUser; refactor only with no functional changes.

Resolution: closed resolved

Reason: PR #2904 was approved and merged as commit 939eb0eed. It centralizes system-username parsing in SystemUser while preserving existing behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Tidy it up a bit in preparation for further cleanup of from_dict(). No functional changes. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2904 as commit 939eb0eed, moving Snap.from_dict() system-username parsing into SystemUser; refactor only with no functional changes.
stealth/space-bunny-alpha — closed resolved Merged PR #2904 (commit 939eb0eed), moving Snap.from_dict() system-username parsing into SystemUser; refactoring only, with no functional changes.
qwen/qwen3.6-35b-a3b — — Merged a refactoring moving Snap's from_dict() system-username parsing into the SystemUser class. Improves code organization for future cleanup with no functional impact. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring that moves Snap's from_dict() system-username parsing into the SystemUser class. Introduces no functional changes and prepares for further from_dict() cleanup.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2858 (confidence 85%)

    Merged PR #2858 introduced the system-usernames functionality that #2904 refactored.

Related issues

No related issues found above the similarity threshold.