← Back to issue list

add support for system-usernames

View original Github issue

Metadata

Project
snapcraft
Number
#2858
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged as bad4d2d69, adding system-usernames support and schema tests for LP #1845267.

Resolution: closed resolved

Reason: PR #2858 was merged as commit bad4d2d69, adding system-usernames support and schema tests. Follow-up PR #2904 refactored the parsing implementation, while #2953 removed the remaining __dict__ usage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP #1845267

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as bad4d2d69, adding system-usernames support and schema tests for LP #1845267.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#2858 as commit bad4d2d69, adding system-usernames support and schema tests for LP #1845267.
qwen/qwen3.6-35b-a3b — — Merged pull request adding system-usernames support per LP #1845267. Approved by one reviewer, it adds schema tests and modifies eight files. The author noted the implementation temporarily bypasses the __dict__ model, with cleanup planned later.
qwen3.6-35b-a3b-mtp-q6 — — Merged system-username support and schema tests. Implementation addresses the __dict__ model mismatch, with cleanup scheduled for a follow-up PR. Resolves LP #1845267.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2904 (confidence 98%)

    Merged as 939eb0eed to move system-username parsing into SystemUser without changing behavior.

  • Related To: canonical/snapcraft#2953 (confidence 96%)

    Merged as ef4d64e8d to remove remaining __dict__ and key-list usage from Snap metadata.

Related issues

Issue Project State Summary Similarity
#2838 add support for system-usernames snapcraft closed Closed while the rebased work was split into smaller PRs; system-usernames support and schema tests landed separately in merged PR #2858 via commit bad4d2d69.
90%
#3964 schema,tests: add support for new system usernames snapcraft merged Merged #3964 as 92a9614f5, updating the schema and tests to accept additional system usernames supported by snapd.
81%
#3746 project: support system-usernames snapcraft merged Merged #3746 added support for system-usernames, relaxing project validation and deferring stricter errors to snap pack; merge commit 1122de9d0.
73%
#1845267 please support system-usernames, new in snapd 2.41 snapcraft (launchpad) closed System-username support was implemented, including both YAML forms and long-form snap.yaml output, by merged PR snapcore/snapcraft#2858 (commit bad4d2d69).
71%