← Back to issue list

sanity_checks: fix sanity check on Windows

View original Github issue

Metadata

Project
snapcraft
Number
#2919
Type
pull request
State
merged
Author
NickZ
Labels
Created
Updated
Closed

Current evaluation

Merged fix for Windows sanity check failures in snap directory validation. Updated path checks to handle backslashes correctly. Approved by reviewers, passed CI, and integrated.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- The sanity checks for expected snap directories were not checking to see if the path had backslashes in it, so the sanity check was failing on Windows. This fixes it.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for Windows sanity check failures in snap directory validation. Updated path checks to handle backslashes correctly. Approved by reviewers, passed CI, and integrated.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for Windows-specific sanity check failures. The update ensures snap directory path validation correctly handles backslashes, resolving test failures on Windows systems.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for Windows sanity check failures. Snap directory validation previously failed due to unhandled backslashes in paths. Updated path parsing to correctly process Windows backslashes, resolving the issue.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2279 sanity checks: run properly on build VMs snapcraft merged Merged. Updated snap directory sanity checks from cwd-relative to project-relative paths to resolve build VM failures. Resolves LP: #1792962. Approved by one reviewer with 14 additions and 7 deletions across two files.
84%
#2268 sanity checks: allow snap/local dir snapcraft merged Merged, enabling snap/local in sanity checks to resolve LP: #1792203. Approved after test fixes. Later comments requested allowing dotfiles and READMEs, but the core functionality was successfully integrated.
77%