sanity checks: allow snap/local dir
Metadata
Current evaluation
Merged, enabling snap/local in sanity checks to resolve LP: #1792203. Approved after test fixes. Later comments requested allowing dotfiles and READMEs, but the core functionality was successfully integrated.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
It's natural for folks to want to put all snap-specific files into the `snap/` directory. This PR resolves [LP: #1792203](https://bugs.launchpad.net/snapcraft/+bug/1792203) by giving them a place to do that: `snap/local/`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged, enabling snap/local in sanity checks to resolve LP: #1792203. Approved after test fixes. Later comments requested allowing dotfiles and READMEs, but the core functionality was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enables snap/local/ for snap-specific files, resolving LP: #1792203. Tests updated. A later comment requested allowing dotfiles and READMEs in snap/, but the PR was merged as implemented. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to allow the snap/local directory for snap-specific files, resolving sanity check restrictions. Tests were updated during review to enforce the change. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2279 sanity checks: run properly on build VMs | snapcraft | merged | Merged. Updated snap directory sanity checks from cwd-relative to project-relative paths to resolve build VM failures. Resolves LP: #1792962. Approved by one reviewer with 14 additions and 7 deletions across two files. | |
| #2919 sanity_checks: fix sanity check on Windows | snapcraft | merged | Merged fix for Windows sanity check failures in snap directory validation. Updated path checks to handle backslashes correctly. Approved by reviewers, passed CI, and integrated. |