sanity checks: allow snap/local dir
Metadata
Current evaluation
Merged PR #2268 via commit 10bdb0473 allowed snapcraft-specific files under snap/local/ and added tests, resolving LP #1792203.
Resolution: closed resolved
Reason: PR #2268 was merged, with commit 10bdb0473 implementing the snap/local allowance and corresponding tests. The later request for broader dotfile and README support was a separate scope extension.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
It's natural for folks to want to put all snap-specific files into the `snap/` directory. This PR resolves [LP: #1792203](https://bugs.launchpad.net/snapcraft/+bug/1792203) by giving them a place to do that: `snap/local/`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2268 via commit 10bdb0473 allowed snapcraft-specific files under snap/local/ and added tests, resolving LP #1792203. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2268 in commit 10bdb0473, allowing snap-specific files under snap/local/ and resolving LP #1792203. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2268, allowing snap-specific files in snap/local and resolving LP #1792203. Later comment requested broader dotfile/README allowances. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2268 (commit 10bdb0473), allowing snapcraft sanity checks to accept snap/local for local sources and resolving LP #1792203. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged, enabling snap/local in sanity checks to resolve LP: #1792203. Approved after test fixes. Later comments requested allowing dotfiles and READMEs, but the core functionality was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enables snap/local/ for snap-specific files, resolving LP: #1792203. Tests updated. A later comment requested allowing dotfiles and READMEs in snap/, but the PR was merged as implemented. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#2502
(confidence 85%)
Later commit e48cd84d6 addressed management of snap/local as follow-up work.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1792203 Add support for snap/local directory | snapcraft (launchpad) | closed | snap/local support was merged in canonical/snapcraft#2268 via commit 10bdb0473, allowing snap-specific local-source files and adding tests. | |
| #2279 sanity checks: run properly on build VMs | snapcraft | merged | Merged snapcraft#2279 in commit 6f4ca585f, making snap-directory sanity checks project-relative instead of CWD-relative so they work on build VMs (LP #1792962). | |
| #2256 local source: don't include .snapcraft directory | snapcraft | merged | Merged #2256 (commit abbc92427), fixing LP #1791773 by excluding .snapcraft from local-source copies and stale-part checks. | |
| #2502 meta: fix management of snap/local | snapcraft | merged | Merged PR #2502 stopped snap/local from being copied into built snaps and improved copying for embedded directories in commit e48cd84d6. | |
| #2919 sanity_checks: fix sanity check on Windows | snapcraft | merged | Merged PR #2919 fixed Windows sanity checks for expected snap directories by allowing backslash paths; landed as commit cc40d5f68. |