← Back to issue list

storeapi: remove exposure of series

View original Github issue

Metadata

Project
snapcraft
Number
#2921
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2921 as commit 071ad06cd, removing deprecated series exposure from storeapi and reworking SnapNotFoundError to use SnapcraftException.

Resolution: closed resolved

Reason: PR snapcraft#2921 was merged as commit 071ad06cd, completing the removal of deprecated series exposure and updating SnapNotFoundError.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Series, mostly used with constants.DEFAULT_SERIES has been long deprecated and has not use. Remove its broad exposure across the code base. No great changes should be observed aside from reworking how SnapNotFoundError is implemented by making use of the new SnapcraftException. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2921 as commit 071ad06cd, removing deprecated series exposure from storeapi and reworking SnapNotFoundError to use SnapcraftException.
stealth/space-bunny-alpha — closed resolved Merged PR #2921 as commit 071ad06cd: dropped the long-deprecated series/constants.DEFAULT_SERIES exposure across storeapi and its callers (16 files, +323/-357), also reworking SnapNotFoundError onto SnapcraftException.
stealth/space-bunny-alpha — closed resolved Merged PR #2921 as commit 071ad06cd, removing deprecated series exposure from storeapi and refactoring SnapNotFoundError to use SnapcraftException.
qwen/qwen3.6-35b-a3b — — Merged following reviewer approval and passing CI. Removed deprecated Series exposure from storeapi and refactored SnapNotFoundError to use SnapcraftException across 16 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of deprecated Series exposure from storeapi and refactored SnapNotFoundError to use SnapcraftException. The update cleans up the codebase without altering core functionality.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3403 storeapi: remove unused MissingSnapdError snapcraft merged Merged cleanup by maintainer sergiusens removing the unused storeapi.MissingSnapdError exception class (11 lines deleted in 1 file) as commit 5a7cef39d, merged via PR #3403 with 1 approving review and no CI failures.
72%