← Back to issue list

storeapi: remove exposure of series

View original Github issue

Metadata

Project
snapcraft
Number
#2921
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged following reviewer approval and passing CI. Removed deprecated Series exposure from storeapi and refactored SnapNotFoundError to use SnapcraftException across 16 files.

Suggested action: —

No scores available.

Issue body

Series, mostly used with constants.DEFAULT_SERIES has been long deprecated and has not use. Remove its broad exposure across the code base. No great changes should be observed aside from reworking how SnapNotFoundError is implemented by making use of the new SnapcraftException. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged following reviewer approval and passing CI. Removed deprecated Series exposure from storeapi and refactored SnapNotFoundError to use SnapcraftException across 16 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of deprecated Series exposure from storeapi and refactored SnapNotFoundError to use SnapcraftException. The update cleans up the codebase without altering core functionality.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of deprecated Series exposure from storeapi. SnapNotFoundError was reworked to use SnapcraftException, cleaning up the codebase without altering external behavior.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3403 storeapi: remove unused MissingSnapdError snapcraft merged Merged removal of the unused MissingSnapdError class from the storeapi module. The change deleted 11 lines across one file, passed CI checks, received approval, and was successfully integrated into the main branch.
70%