← Back to issue list

storeapi: remove unused MissingSnapdError

View original Github issue

Metadata

Project
snapcraft
Number
#3403
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged cleanup by maintainer sergiusens removing the unused storeapi.MissingSnapdError exception class (11 lines deleted in 1 file) as commit 5a7cef39d, merged via PR #3403 with 1 approving review and no CI failures.

Resolution: closed resolved

Reason: PR #3403 was merged into the repository as commit 5a7cef39d ("storeapi: remove unused MissingSnapdError"), deleting the dead exception class after it stopped being referenced. A pickaxe search confirms MissingSnapdError no longer appears anywhere in the current tree, so the dead-code removal is complete.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged cleanup by maintainer sergiusens removing the unused storeapi.MissingSnapdError exception class (11 lines deleted in 1 file) as commit 5a7cef39d, merged via PR #3403 with 1 approving review and no CI failures.
stealth/space-bunny-alpha — closed resolved Merged in #3403 (commit 5a7cef39d), removing 11 unused lines for storeapi.MissingSnapdError.
qwen/qwen3.6-35b-a3b — — Merged removal of the unused MissingSnapdError class from the storeapi module. The change deleted 11 lines across one file, passed CI checks, received approval, and was successfully integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the unused MissingSnapdError class from the storeapi module. Maintainer sergiusens submitted the cleanup, which was integrated into the codebase without additional review comments.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/snapcraft#3399 (confidence 60%)

    Commit b0c28197e 'cli: do not require snapd deb for assertions (#3399)' and commit 76130d506 'cli: stop handling exceptions in assertions' removed the last handling of MissingSnapdError, leaving the class unused and prompting this cleanup.

  • Related To: canonical/snapcraft#3399 (confidence 55%)

    Same storeapi/CLI error-handling simplification series; the preceding PR dropped the code path that raised MissingSnapdError.

Related issues

Issue Project State Summary Similarity
#806 Remove snapcraft.storeapi.common snapcraft merged PR #806 merged (commit c810dedd) by cjwatson, deleting the unused snapcraft/storeapi/common.py (-192 lines, 5 files) after all callers moved to StoreClient, and dropping the requests-oauthlib dependency.
74%
#2921 storeapi: remove exposure of series snapcraft merged Merged PR #2921 as commit 071ad06cd, removing deprecated series exposure from storeapi and reworking SnapNotFoundError to use SnapcraftException.
72%
#2059 storeapi: handle 500 error response when releasing snap snapcraft merged Merged PR #2059 via commit 3a861f74c fixed snap release handling of HTML 500 responses, added debug output for store errors, and resolved #2028.
70%
#3332 storeapi: remove bindings for history snapcraft merged Merged in snapcraft#3332 as commit 377cbeca6, removing legacy storeapi history bindings and 180 lines across six files.
70%
#3686 storeapi: export SnapAPI snapcraft merged Exported SnapAPI from storeapi and merged it into snapcraft/7.0 via PR #3686 (merge e5a1886b5, commit 1d7c2c12d), completing CRAFT-1021.
70%