← Back to issue list

meta: fix for missing content slot's 'content' property

View original Github issue

Metadata

Project
snapcraft
Number
#2934
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2934 fixed content-slot metadata initialization so snapcraft.yaml content is retained, with added unit coverage; landed as commit 4644651c4.

Resolution: closed resolved

Reason: The approved PR was merged as commit 4644651c4, correcting ContentSlot creation from snapcraft.yaml and adding tests for explicit content.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Content was not being initialized correctly from the snapcraft.yaml. Ensure it is used to create ContentSlot. Update existing tests to ensure coverage of explicit content. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2934 fixed content-slot metadata initialization so snapcraft.yaml content is retained, with added unit coverage; landed as commit 4644651c4.
stealth/space-bunny-alpha — closed resolved Merged PR #2934 fixed content slots missing snapcraft.yaml content initialization, with tests covering explicit content and 100% diff coverage.
qwen/qwen3.6-35b-a3b — — Merged fix for missing 'content' property initialization in content slots from snapcraft.yaml. Includes updated tests for explicit content coverage. Approved, passed CI, and achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix ensuring the content slot content property initializes correctly from snapcraft.yaml. Updated tests achieve 100 percent diff coverage.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3227 (confidence 95%)

    Follow-up fix addressed deriving content-slot content when the source key was used.

Related issues

Issue Project State Summary Similarity
#3227 meta: fix content slot to set content when using source key snapcraft merged Merged in canonical/snapcraft#3227 (commit 8cdbe2692), fixing content slots to preserve the content value when source is specified and adding unit tests.
85%
#3874 meta: fix content plug detection snapcraft merged Merged PR #3874 in commit b962783c1, allowing empty content plug/slot definitions and deferring type validation until snap packaging.
78%
#3959 meta: fix snap.yaml app slots snapcraft merged Merged snapcraft#3959 in commit 2d09913e7, adding missing app slot definitions to snap.yaml.
76%