build providers: remove tzdata workaround
Metadata
Current evaluation
Merged changes remove an outdated tzdata workaround from build providers. The underlying issue was resolved by adding --preserve-env in a prior commit, rendering the workaround obsolete. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
This workaround was put in place, but it is the wrong fix.
The underlying problem was fixed with the addition of --preserve-env
on commit:
97fdf64b731e23f02898e7921e838a2fc80a6c5d
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes remove an outdated tzdata workaround from build providers. The underlying issue was resolved by adding --preserve-env in a prior commit, rendering the workaround obsolete. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the tzdata workaround. The underlying issue was resolved by adding --preserve-env in commit 97fdf64, making the workaround obsolete. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the tzdata workaround after the underlying issue was resolved by adding the --preserve-env flag in commit 97fdf64. The workaround was deemed incorrect and is no longer required. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2964 build providers: remove LXD specific env setup | snapcraft | merged | Merged. Removes LXD-specific environment setup from build providers since Provider._get_env_command already handles it. Approved by reviewer, passed CI, and successfully integrated. | |
| #2940 build providers: remove use of cloud-init | snapcraft | merged | Merged changes removing cloud-init from build providers. Refactored to use _run and _push_file methods, isolating initial setup. Approved by reviewer, passed CI, and updated six files. | |
| #5537 docs: update build provider procedures | snapcraft | merged | Merged documentation update to build provider procedures, resolving issue #5519. Approved by two reviewers and passed most CI checks despite minor integration test failures. Changes span four files with 100 lines added and 98 removed. | |
| #2474 build providers: remove dead code | snapcraft | merged | Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines). | |
| #2374 build providers: destroy on create failures | snapcraft | merged | Merged. Resolves a bug where build providers and VMs remained running after launch failures. Adds cleanup logic and tests across seven files, approved by a reviewer and passing CI checks. | |
| #2508 Build provider errors | snapcraft | merged | Merged after approval and passing CI checks. Resolved build provider errors across two files (+353/-85 lines). Codecov reported 90.62% diff coverage. | |
| #3202 build providers: fix base change warning message | snapcraft | merged | Merged after approval and passing CI. The pull request fixes the base change warning message in build providers, updating one file with four additions and two deletions. |