build providers: remove tzdata workaround
Metadata
Current evaluation
Merged #2935 in commit 1fdd243c1, removing the build-provider tzdata workaround after commit 97fdf64 added --preserve-env.
Resolution: closed resolved
Reason: PR #2935 was merged as commit 1fdd243c1. It removed the incorrect workaround because commit 97fdf64b731e23f02898e7921e838a2fc80a6c5d had fixed environment propagation with --preserve-env.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This workaround was put in place, but it is the wrong fix.
The underlying problem was fixed with the addition of --preserve-env
on commit:
97fdf64b731e23f02898e7921e838a2fc80a6c5d
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2935 in commit 1fdd243c1, removing the build-provider tzdata workaround after commit 97fdf64 added --preserve-env. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 1fdd243c1 (#2935), removing the incorrect tzdata workaround after --preserve-env fixed the underlying problem in 97fdf64b7. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2935 (commit 1fdd243c1), removing the obsolete tzdata workaround because commit 97fdf64b7 had fixed the underlying problem by adding --preserve-env. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes remove an outdated tzdata workaround from build providers. The underlying issue was resolved by adding --preserve-env in a prior commit, rendering the workaround obsolete. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the tzdata workaround. The underlying issue was resolved by adding --preserve-env in commit 97fdf64, making the workaround obsolete. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#2407
(confidence 98%)
This earlier PR introduced the timezone workaround later removed by #2935.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2407 build providers: preset the timezone | snapcraft | merged | Merged PR #2407 in commit a469ca65d, setting build-provider timezones from the host via cloud-init and falling back to Etc/UTC. | |
| #2964 build providers: remove LXD specific env setup | snapcraft | merged | Merged PR #2964 as ed63a021b, removing redundant LXD environment setup because Provider._get_env_command already handles the build environment. |