build providers: remove LXD specific env setup
Metadata
Current evaluation
Merged PR #2964 as ed63a021b, removing redundant LXD environment setup because Provider._get_env_command already handles the build environment.
Resolution: closed resolved
Reason: The approved PR was merged as commit ed63a021b, consolidating build-environment setup in Provider._get_env_command.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Get rid of the LXD specific environment handling considering that
everything is already driven by Provider._get_env_command
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2964 as ed63a021b, removing redundant LXD environment setup because Provider._get_env_command already handles the build environment. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #2964 (ed63a021b), removing LXD-specific environment setup because Provider._get_env_command already handles the build environment. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Removes LXD-specific environment setup from build providers since Provider._get_env_command already handles it. Approved by reviewer, passed CI, and successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed LXD-specific environment setup as Provider._get_env_command already handles it. Approved despite minor CI test quote formatting differences. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3033 build providers: do not print network test output for LXD | snapcraft | merged | Merged PR #3033 via commit e335de69e, suppressing getent hosts snapcraft.io output during LXD build-provider environment setup. | |
| #3281 build providers: hide systemd setup for LXD | snapcraft | merged | Merged in PR #3281 (commit 8029036c6), hiding verbose LXD systemd setup output by default while preserving it in internal debug logs. | |
| #5537 docs: update build provider procedures | snapcraft | merged | Merged PR #5537 in commit 6ac28562d, updating build-provider docs to remove sudo/user-group steps and correct LXD initialization; fixes #5519. | |
| #2678 cli: introduce --provider | snapcraft | merged | Merged PR #2678 as commit b1bee8d99, introducing a unified --provider option for host, LXD, and Multipass and consolidating provider-specific build and clean flags. | |
| #2647 build providers: catch LXD socket error | snapcraft | merged | Merged PR #2647 as commit d1902b8cb, adding error handling for LXD socket failures in build providers. | |
| #2935 build providers: remove tzdata workaround | snapcraft | merged | Merged #2935 in commit 1fdd243c1, removing the build-provider tzdata workaround after commit 97fdf64 added --preserve-env. | |
| #2966 build providers: move to buildd images | snapcraft | merged | Merged as commit 916097e6d, moving LXD build providers to Ubuntu buildd images to support all architectures and core20. | |
| #3115 build providers: ignore missing LXD instance when cleaning project | snapcraft | merged | Merged PR #3115 (commit 8ce59011a) makes project cleanup ignore missing LXD instances deleted manually. | |
| #354 Prefer `--use-lxd` over `CRAFT_BUILD_ENVIRONMENT` | craft-application | closed | Fixed in PR #1229 by updating _use_provider to check --use-lxd before CRAFT_BUILD_ENVIRONMENT, ensuring CLI flags take priority. |