build providers: remove LXD specific env setup
Metadata
Current evaluation
Merged. Removes LXD-specific environment setup from build providers since Provider._get_env_command already handles it. Approved by reviewer, passed CI, and successfully integrated.
Suggested action: —
No scores available.
Issue body
Get rid of the LXD specific environment handling considering that
everything is already driven by Provider._get_env_command
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Removes LXD-specific environment setup from build providers since Provider._get_env_command already handles it. Approved by reviewer, passed CI, and successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed LXD-specific environment setup as Provider._get_env_command already handles it. Approved despite minor CI test quote formatting differences. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed LXD-specific environment setup since Provider._get_env_command handles it. Approved by @cjp256, who noted minor unit test failures likely stemming from quote formatting changes in test output. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3281 build providers: hide systemd setup for LXD | snapcraft | merged | Merged to hide verbose systemd setup output for LXD build providers. Approved by one reviewer, passed CI, and modified two files to streamline console output while preserving internal debug visibility. | |
| #2966 build providers: move to buildd images | snapcraft | merged | Merged. Moves build providers to buildd images, enabling multi-architecture and core20 support for LXD. Approved, passed CI, and addressed reviewer feedback on network wait logic. | |
| #3052 build providers: wait for systemd and better nameserver setup on LXD | snapcraft | merged | Merged. Updated LXD build provider to handle systemd degraded state, enable core20 tests, and configure nameserver resolution via systemd-resolved with env var override. Approved, passed CI, +154/-50 lines across 8 files. | |
| #2509 build providers: initial support for LXD | snapcraft | merged | Merged initial LXD build provider support for snapcraft, enabling the --use-lxd flag for lifecycle steps and cleaning. Passes CI. Reviewers noted minor dependency and container setup edge cases, which were clarified or deferred. | |
| #2935 build providers: remove tzdata workaround | snapcraft | merged | Merged changes remove an outdated tzdata workaround from build providers. The underlying issue was resolved by adding --preserve-env in a prior commit, rendering the workaround obsolete. Approved and passed CI. | |
| #2940 build providers: remove use of cloud-init | snapcraft | merged | Merged changes removing cloud-init from build providers. Refactored to use _run and _push_file methods, isolating initial setup. Approved by reviewer, passed CI, and updated six files. | |
| #2647 build providers: catch LXD socket error | snapcraft | merged | Merged to catch LXD socket errors in build providers, resolving SNAPCRAFT-WA. Approved by reviewer, passed CI checks, and integrated with a 14-line addition and 6-line deletion across three files. Minor test coverage decrease noted but did not block merge. | |
| #2631 spread tests: enable LXD build provider tests | snapcraft | merged | Merged into master. Enabled LXD build provider tests by relocating setup to the early prepare phase to reduce overhead and consolidating declarations from task.yaml to spread.yaml. Approved, passed CI, and increased coverage by 0.01%. | |
| #3033 build providers: do not print network test output for LXD | snapcraft | merged | Merged changes to suppress network test output during LXD environment setup. The update modifies two files to prevent printing getent hosts snapcraft.io results, passed CI checks, and received reviewer approval. | |
| #2621 build providers: support injection for LXD | snapcraft | merged | Merged after approval and passing CI. Implements LXD injection support via snapd's new file API, removes legacy mounts, and refactors code for better separation of concerns across 12 files. |