build providers: remove SIGUSR1 signal ignore workaround for multipass
Metadata
Current evaluation
Merged PR #2447 (commit a2ef08109) removed Snapcraft's SIGUSR1-ignore workaround after Multipass fixed the underlying bug upstream in canonical/multipass#221.
Resolution: closed resolved
Reason: The approved PR was merged as commit a2ef08109 after CanonicalLtd/multipass#221 fixed the underlying issue, allowing Snapcraft to remove the obsolete workaround.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The issue has been fixed upstream (CanonicalLtd/multipass#221).
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2447 (commit a2ef08109) removed Snapcraft's SIGUSR1-ignore workaround after Multipass fixed the underlying bug upstream in canonical/multipass#221. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2447 removed Snapcraft's SIGUSR1-ignore workaround after CanonicalLtd/multipass#221 fixed the underlying issue; merged as a2ef08109. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2447 in commit a2ef08109, removing the Multipass SIGUSR1 ignore workaround after the underlying problem was fixed upstream in CanonicalLtd/multipass#221. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of the SIGUSR1 signal ignore workaround for multipass following an upstream fix. The change deletes 11 lines of code, passed CI checks, and received reviewer approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup removing the SIGUSR1 signal ignore workaround for multipass following an upstream fix in CanonicalLtd/multipass#221. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
multipass#221
(confidence 100%)
The cited upstream Multipass fix resolved the behavior that had required Snapcraft's workaround.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2869 build providers: use multipass from stable | snapcraft | merged | Merged in canonical/snapcraft#2869 (commit eb9bd8fbf), switching build providers to install Multipass 1.0 from the stable channel. | |
| #2258 build providers: snapcraft images for multipass | snapcraft | merged | Merged PR #2258 as commit 5ffefbf96, adding Snapcraft build images for Multipass and a Darwin launch workaround for LP #1791821. | |
| #2293 build providers: use the new snapcraft: remote for multipass | snapcraft | merged | Merged PR #2293 as commit 66060e839, switching Multipass builds to the snapcraft: remote and delegating unsupported-base errors to Multipass. | |
| #3275 cli: ignore sudo warning when using multipass | snapcraft | merged | Merged #3275 in commit cb23c00a5, suppressing Snapcraft's sudo warning when the Multipass build provider is used. | |
| #2288 build providers: use multipass automatically when on darwin | snapcraft | merged | Merged #2288 as commit 376adda59, making Snapcraft select Multipass automatically on Darwin/macOS and resolving LP #1793512. | |
| #1861011 Multipass bug prevents snapcraft from building on windows when using base keyword | snapcraft (launchpad) | closed | The Windows hang was an upstream Multipass defect; canonical/multipass#1170 fixed it on master for release 1.1. | |
| #2961 build providers: remove over use of -i in sudo | snapcraft | merged | Merged PR #2961 as commit 54528c17f, removing unnecessary sudo -i flags from build-provider commands to prevent Multipass ioctl warnings when stdin is /dev/null. | |
| #1799780 root user handling for multipass is confusing | snapcraft (launchpad) | closed | Fixed by merged snapcore/snapcraft#2385 (commit 404255671), consolidating CLI re-execution and delegating Multipass root handling to build-provider APIs. | |
| #1792614 use multipass if set in the environment | snapcraft (launchpad) | closed | Closed as fixed: PR snapcore/snapcraft#2275 (commit 04f8896d9) made SNAPCRAFT_BUILD_ENVIRONMENT/multipass take precedence over the base-derived provider choice. | |
| #2507 build providers: improve handling in snap logic | snapcraft | merged | Merged snapcraft#2507 as commit 841b41fa3, improving build-provider snap logic, removing unnecessary sudo calls, and silencing refresh-hold noise. |