build providers: remove SIGUSR1 signal ignore workaround for multipass
Metadata
Current evaluation
Merged removal of the SIGUSR1 signal ignore workaround for multipass following an upstream fix. The change deletes 11 lines of code, passed CI checks, and received reviewer approval.
Suggested action: —
No scores available.
Issue body
The issue has been fixed upstream (CanonicalLtd/multipass#221).
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of the SIGUSR1 signal ignore workaround for multipass following an upstream fix. The change deletes 11 lines of code, passed CI checks, and received reviewer approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup removing the SIGUSR1 signal ignore workaround for multipass following an upstream fix in CanonicalLtd/multipass#221. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the SIGUSR1 signal ignore workaround for multipass. The upstream multipass project resolved the underlying issue, allowing cleanup of the legacy build provider code. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2961 build providers: remove over use of -i in sudo | snapcraft | merged | Merged changes removing unnecessary -i flags from sudo commands in build providers. This resolves an ioctl warning in Multipass when stdin is set to DEVNULL. Approved by one reviewer, passed CI, and modified four files. | |
| #2345 build providers: remove the qemu implementation | snapcraft | merged | Merged the removal of the QEMU build provider implementation, superseded by multipass. The change deleted 1062 lines across 12 files after approval and passing CI checks. | |
| #2511 build providers: modify the _run signature | snapcraft | merged | Merged changes modifying the _run signature in build providers to return output. Updates the Multipass implementation to wrap execute calls. Approved by reviewer and passed CI checks. | |
| #2869 build providers: use multipass from stable | snapcraft | merged | Merged update to consume Multipass 1.0 from the stable channel for build providers. Approved by one reviewer, modifying four files with minimal changes. | |
| #2284 build providers: make use of time for multipass stop | snapcraft | merged | Updated build providers to use time for Multipass stop operations, resolving Launchpad bug #1793288. Merged after approval and passing CI checks across four files. |