← Back to issue list

vcs: add direnv files to .gitignore

View original Github issue

Metadata

Project
snapcraft
Number
#2980
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2980 (commit d652ca825) added .direnv to snapcraft's .gitignore so direnv-generated environment artifacts stay out of version control; follow-ups #2985 and #3028 excluded .direnv from static/codespell checks.

Resolution: closed resolved

Reason: The PR itself was merged into snapcraft's main branch as commit d652ca825 ('vcs: add direnv files to .gitignore (#2980)'), a 3-line change to .gitignore; the '.direnv' entry is still present at .gitignore:129 in the current tree. Related follow-ups were merged separately: #2985 (cf0e00311) and #3028 (e6c3f09af).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2980 (commit d652ca825) added .direnv to snapcraft's .gitignore so direnv-generated environment artifacts stay out of version control; follow-ups #2985 and #3028 excluded .direnv from static/codespell checks.
stealth/space-bunny-alpha — closed resolved Merged PR #2980 added direnv-generated files to .gitignore, preventing local environment artifacts from entering version control.
stealth/space-bunny-alpha — closed resolved Merged PR #2980 added direnv-generated files to .gitignore, preventing local environment artifacts from entering version control.
qwen/qwen3.6-35b-a3b — — Merged to add direnv files to .gitignore. Approved by one reviewer with no unresolved comments. The change adds three lines to a single file.
qwen3.6-35b-a3b-mtp-q6 — — Merged maintainer sergiusens' update to add direnv files to .gitignore, ensuring they are excluded from version control tracking.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2985 (confidence 88%)

    Merged follow-up (commit cf0e00311) that made static checks ignore the same direnv-created artifacts.

  • Related To: canonical/snapcraft#3028 (confidence 80%)

    Merged follow-up (commit e6c3f09af) adding .direnv to codespell excludes, completing the direnv handling.

Related issues

Issue Project State Summary Similarity
#301 gitignore: ignore .envrc for direnv users charmcraft merged Merged PR #301 (commit 8b39a96e, merged via 6634a184) added .envrc to charmcraft's .gitignore under a "# direnv" comment so direnv users' env files stay untracked; approved by 2 reviewers.
75%
#2985 static: ignore direnv created artifacts snapcraft merged Merged in snapcraft#2985 as commit cf0e00311, adding static-check exclusions for .direnv so Black and flake8 would not process direnv's Python artifacts.
75%
#3028 static: add codespell excludes for .direnv snapcraft merged Merged PR #3028 added .direnv to codespell's static-check exclusions; merged as commit e6c3f09af.
71%
#75 .gitignore: ignore direnv's .envrc file starbase merged PR #75 merged as commit 01be79d, adding direnv's .envrc to starbase's .gitignore (still present in current HEAD). Trivial maintainer housekeeping change, approved with no review comments.
70%