← Back to issue list

static: ignore direnv created artifacts

View original Github issue

Metadata

Project
snapcraft
Number
#2985
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#2985 as commit cf0e00311, adding static-check exclusions for .direnv so Black and flake8 would not process direnv's Python artifacts.

Resolution: closed resolved

Reason: PR #2985 was approved and merged as commit cf0e00311. Its two-line change excludes .direnv from the relevant static-analysis tools.

Evaluated by: mr-cal-bot

No scores available.

Issue body

direnv creates a .direnv when using a pyenv layout that holds python's standard libraries which black modifies and flake8 fails on. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#2985 as commit cf0e00311, adding static-check exclusions for .direnv so Black and flake8 would not process direnv's Python artifacts.
stealth/space-bunny-alpha — closed resolved Merged #2985 in commit cf0e00311, excluding .direnv artifacts from static checks so Black and flake8 skip direnv-created Python files.
stealth/space-bunny-alpha — closed resolved Merged in #2985 via cf0e00311, excluding .direnv artifacts from static checks so Black and flake8 no longer modify or flag Python’s standard-library files.
stealth/space-bunny-alpha — closed resolved Merged #2985 (cf0e00311), ignoring .direnv in static analysis so Black and flake8 skip direnv-created Python artifacts.
qwen/qwen3.6-35b-a3b — — Merged a fix to ignore direnv artifacts in static analysis. This prevents Black and flake8 from failing or modifying Python standard libraries in the .direnv directory during pyenv layouts. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix to ignore .direnv artifacts generated by pyenv layouts. This prevents Black from modifying Python standard libraries and resolves flake8 failures during static analysis checks.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3028 (confidence 90%)

    Committed as e6c3f09af, later extending static exclusions to codespell for .direnv.

  • Related To: snapcraft#2980 (confidence 88%)

    Committed as d652ca825 shortly beforehand, adding direnv files to VCS ignore rules.

Related issues

Issue Project State Summary Similarity
#2980 vcs: add direnv files to .gitignore snapcraft merged Merged PR #2980 (commit d652ca825) added .direnv to snapcraft's .gitignore so direnv-generated environment artifacts stay out of version control; follow-ups #2985 and #3028 excluded .direnv from static/codespell checks.
75%