repo: remove dead code from deb implementation
Metadata
Current evaluation
PR #2993 merged as commit d7d75b874, stripping dead code from the deb implementation: functions duplicated in _base, unused geoip mirror support, and the unused default sources list.
Resolution: closed resolved
Reason: Merged into snapcraft master as commit d7d75b874 (approved by a maintainer reviewer, 1 review). The pickaxe search confirms the 'geoip' references in the deb implementation were removed by this commit and no longer exist in the tree.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Remove functions are redundant with those found in _base.
- Remove unused geoip support, we'll eventually allow the user
to configre the primary mirrors.
- Remove unused default sources list. We'll always be using
the host's.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2993 merged as commit d7d75b874, stripping dead code from the deb implementation: functions duplicated in _base, unused geoip mirror support, and the unused default sources list. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2993 as commit d7d75b874, removing redundant deb functions, unused geoip support, and the default sources list. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval and passing CI. Removed redundant functions, unused geoip support, and default sources list from the Debian implementation. The change modifies two files, netting 70 deleted lines to streamline the repo module. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup that removes dead code from the deb implementation, including redundant base functions, unused geoip support, and a default sources list. The maintainer-authored changes were merged after a minor CI connectivity failure was noted. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2377
(confidence 80%)
Earlier PR f6ed44e2c removed the geoip CLI toggles, leaving the remaining geoip code in the deb implementation dead; this PR finished that cleanup.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #963 sources: refactor deb source into module. | snapcraft | merged | PR #963 merged as 9aad0e3a5, extracting the Deb source implementation into sources/_deb.py to advance Launchpad bug #1648906. |