← Back to issue list

sources: refactor deb source into module.

View original Github issue

Metadata

Project
snapcraft
Number
#963
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #963 merged as 9aad0e3a5, extracting the Deb source implementation into sources/_deb.py to advance Launchpad bug #1648906.

Resolution: closed resolved

Reason: PR #963 was merged into master in commit 9aad0e3a5, moving Deb source handling into sources/_deb.py to advance Launchpad bug #1648906.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR makes more progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting the Deb source into `sources/_deb.py`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #963 merged as 9aad0e3a5, extracting the Deb source implementation into sources/_deb.py to advance Launchpad bug #1648906.
stealth/space-bunny-alpha — closed resolved Merged PR #963 as commit 9aad0e3a5, extracting the Deb source into sources/_deb.py (+119/-75) as groundwork for Launchpad bug #1648906.
stealth/space-bunny-alpha — closed resolved Merged PR #963 as commit 9aad0e3a5, extracting the Deb source into sources/_deb.py to advance Launchpad bug #1648906.
stealth/space-bunny-alpha — closed resolved Merged #963 as commit 9aad0e3a5, extracting Deb source logic into sources/_deb.py to advance Launchpad bug #1648906.
stealth/space-bunny-alpha — closed resolved Merged #963 as commit 9aad0e3a, extracting the Deb source into sources/_deb.py to advance Launchpad bug #1648906.
stealth/space-bunny-alpha — closed resolved Merged PR #963 (commit 9aad0e3a5), extracting Deb source logic into sources/_deb.py to advance Launchpad #1648906.
qwen/qwen3.6-35b-a3b — — Merged refactoring changes that extract Deb source logic into a dedicated module at sources/_deb.py. This restructuring advances progress on Launchpad bug #1648906 and passes CI checks with maintained code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring that extracts Debian source handling into sources/_deb.py. The change improves code organization and increases overall test coverage to 96.24%.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#269 sources: support "deb" sources craft-parts merged Merged PR #269 in commit d75aa1d8, adding .deb source support via dpkg-deb and sharing extract_deb() with stage-package handling.
76%
#2993 repo: remove dead code from deb implementation snapcraft merged PR #2993 merged as commit d7d75b874, stripping dead code from the deb implementation: functions duplicated in _base, unused geoip mirror support, and the unused default sources list.
73%