← Back to issue list

Add gcc to the build-packages for the gnome-3-34 extension

View original Github issue

Metadata

Project
snapcraft
Number
#2995
Type
pull request
State
merged
Author
hellsworth
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2995 (commit 8963101f5) added gcc to the GNOME 3.34 extension build-packages so Firefox could build in Docker.

Resolution: closed resolved

Reason: PR #2995 was approved and merged. Commit 8963101f5 added gcc to the GNOME 3.34 extension's build-packages, resolving the compiler dependency needed for Firefox builds in Docker.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- Even though gcc is staged in the gnome-3-34-1804-sdk build snap, Ken still needs this to build firefox in docker.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2995 (commit 8963101f5) added gcc to the GNOME 3.34 extension build-packages so Firefox could build in Docker.
stealth/space-bunny-alpha — closed resolved Merged PR #2995 (commit 8963101f5) added gcc to build-packages in the gnome-3-34 extension YAML and updated its unit test, fixing Firefox builds in Docker even though gcc ships in the gnome-3-34-1804-sdk build snap.
stealth/space-bunny-alpha — closed resolved Merged PR #2995 added gcc to gnome-3-34 build-packages, enabling Firefox builds in Docker despite gcc already being present in the SDK build snap.
stealth/space-bunny-alpha — closed resolved Merged PR #2995 (commit 8963101f5), adding gcc to the gnome-3-34 extension's build-packages so Firefox can build in Docker.
qwen/qwen3.6-35b-a3b — — Merged adding gcc to the gnome-3-34 extension build-packages to enable Firefox Docker builds. The contributor resolved test failures caused by missing configuration, and the change was approved and merged after CI passed.
qwen3.6-35b-a3b-mtp-q6 — — Merged addition of gcc to the build-packages for the gnome-3-34 extension. Contributor resolved unit test failures and AppVeyor CI quota issues during review before the change was integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2956 Add gnome 3 34 extension snapcraft merged Merged as #2956 (commit 1a411b0bb), adding the gnome-3-34 extension for core18 and replacing #2794; later follow-ups added gcc build-packages (#2995) and XDG_DATA_DIRS/PYTHONPATH fixes (#3340, #3426).
78%
#3178 extensions: add gcc to GNOME 3.28 extension part snapcraft merged Merged into main as commit fb967fec7, adding gcc to the GNOME 3.28 extension part.
75%