← Back to issue list

extensions: add gcc to GNOME 3.28 extension part

View original Github issue

Metadata

Project
snapcraft
Number
#3178
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged changes adding gcc to the GNOME 3.28 extension part. Approved by one reviewer with passing CI checks. The minimal +2/-2 line diff across two files resolves Launchpad bug #1883392.

Suggested action:

No scores available.

Issue body

LP: #1883392 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes adding gcc to the GNOME 3.28 extension part. Approved by one reviewer with passing CI checks. The minimal +2/-2 line diff across two files resolves Launchpad bug #1883392.
qwen3.6-35b-a3b-mtp-q6 Merged, adding gcc to the GNOME 3.28 extension part to resolve Launchpad issue #1883392. The change was submitted and integrated by maintainer sergiusens without additional review comments.
qwen3.6-35b-a3b-mtp-q6 Added gcc to the GNOME 3.28 extension part, resolving Launchpad bug #1883392. The change was merged by maintainer sergiusens.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4798 extension: fix issues and depreciated vars in gnome extension snapcraft merged Merged changes fixing issues and deprecated variables in the GNOME extension. Approved by two reviewers, passed all CI checks, and modified two files with six additions and six deletions.
75%
#2995 Add gcc to the build-packages for the gnome-3-34 extension snapcraft merged Merged adding gcc to the gnome-3-34 extension build-packages to enable Firefox Docker builds. The contributor resolved test failures caused by missing configuration, and the change was approved and merged after CI passed.
75%
#3427 extensions: make GNOME 3.38 stable snapcraft merged Merged after two approvals and passing CI. The change stabilizes GNOME 3.38 in extensions. Despite a minor overall coverage decrease, the maintainer accepted the 100% diff coverage and proceeded with the merge after resolving a publishing failure.
75%
#3798 extensions: add core22 gnome snapcraft merged Merged into main. Added core22 gnome extension support. Approved by reviewer, passed CI, and increased test coverage by 0.09%. Changes modified 10 files with 707 additions and 1 deletion.
74%
#3407 Add new gnome-3-38 extension which uses gnome-3-38-2004 and core20 snapcraft merged Merged into master following reviewer approval and passing CI. Introduces a new gnome-3-38 extension leveraging gnome-3-38-2004 and core20, adding 357 lines across five files with 95.23% change coverage.
73%
#2956 Add gnome 3 34 extension snapcraft merged Merged into master, adding GNOME 3.34 extension support. Replaced PR #2794, approved by a reviewer, passed CI, and achieved 100% diff coverage before integration.
72%
#3443 extensions: add conditional for GNOME Makefile using bindtextdomain snapcraft merged Merged after approval, adding a Makefile conditional for bindtextdomain.so to support GNOME 3.28 and 3.34 extensions. Reviewer verified LD_PRELOAD safety. Changes modified 7 files (+49/-13 lines).
71%
#2704 extensions: create the gnome-platform directory snapcraft merged Merged changes creating the gnome-platform directory for the gnome platform content interface plug. Approved by reviewer, passed CI, and maintained existing coverage.
70%