repo: use python-apt's fetch_binary implementation
Metadata
Current evaluation
Merged as commit 7396004d6, replacing Snapcraft’s custom repository-fetching logic with python-apt’s fetch_binary implementation and updating mocks, fixtures, and tests.
Resolution: closed resolved
Reason: PR #3009 was approved and merged. Commit 7396004d6 adopted python-apt’s less-verbose fetch_binary() logic after the dependency was updated in PR #2999.
Evaluated by: mr-cal-bot
No scores available.
Issue body
python-apt has been updated to be less verbose, so we can
use the fetch_binary() logic that was lifted from there.
Update mocks, fixture, and tests accordingly.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 7396004d6, replacing Snapcraft’s custom repository-fetching logic with python-apt’s fetch_binary implementation and updating mocks, fixtures, and tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3009 (commit 7396004d6), replacing custom repository fetching with python-apt's fetch_binary() and updating mocks, fixtures, and tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged implementation replaces custom repository fetching with python-apt's fetch_binary() method. Updated mocks, fixtures, and tests. Approved by one reviewer, passed CI checks, and reduced code by 89 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adopted python-apt's fetch_binary() implementation following its verbosity reduction. Updated associated mocks, fixtures, and unit tests to align with the new logic. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#2999
(confidence 96%)
The preceding python-apt 1.6.0 update enabled the less-verbose implementation used here.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3000 repo: use python-apt's fetch_binary implementation | snapcraft | closed | Closed unmerged in favour of PR #3009, which carried the same change (python-apt's fetch_binary() replacing custom repo fetching) and merged as commit 7396004d6; prerequisite PR #2999 had already merged as fff41f246. |