← Back to issue list

repo: use python-apt's fetch_binary implementation

View original Github issue

Metadata

Project
snapcraft
Number
#3000
Type
pull request
State
closed
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged in favour of PR #3009, which carried the same change (python-apt's fetch_binary() replacing custom repo fetching) and merged as commit 7396004d6; prerequisite PR #2999 had already merged as fff41f246.

Resolution: closed superseded

Reason: PR #3000 was closed without merging and superseded by the identically titled PR #3009, which merged to main as commit 7396004d6. Its stated dependency, PR #2999 (bionic python-apt 1.6.0 uprev), had already merged as fff41f246, and a follow-up fix landed later in 638740ae1.

Evaluated by: mr-cal-bot

No scores available.

Issue body

python-apt has been updated to be less verbose, so we can use the fetch_binary() logic that was lifted from there. Update mocks, fixture, and tests accordingly. Depends on https://github.com/snapcore/snapcraft/pull/2999

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged in favour of PR #3009, which carried the same change (python-apt's fetch_binary() replacing custom repo fetching) and merged as commit 7396004d6; prerequisite PR #2999 had already merged as fff41f246.
stealth/space-bunny-alpha — closed superseded Closed in favor of PR #3009, which merged as 7396004d6 and replaced custom repository fetching with python-apt's fetch_binary().
qwen/qwen3.6-35b-a3b — — Closed without merging, likely abandoned or superseded due to pending review and unresolved comments. The change aimed to replace custom logic with python-apt's fetch_binary() implementation and update associated tests.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merge. Proposed refactoring the repository module to use python-apt's fetch_binary logic with updated mocks and tests. Remains pending dependency PR #2999.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3009 (confidence 98%)

    Same title and scope; merged as 7396004d6, replacing custom repository fetching with python-apt's fetch_binary() and updating mocks, fixtures and tests.

  • Blocked By: canonical/snapcraft#2999 (confidence 90%)

    Declared dependency; merged as fff41f246 to uprev the bionic python-apt package to 1.6.0 before fetch_binary() could be used.

  • Related To: canonical/snapcraft#3030 (confidence 60%)

    Later follow-up (66467629d) dropping _AptCache in the same repository code path after the fetch_binary change landed.

Related issues

Issue Project State Summary Similarity
#3009 repo: use python-apt's fetch_binary implementation snapcraft merged Merged as commit 7396004d6, replacing Snapcraft’s custom repository-fetching logic with python-apt’s fetch_binary implementation and updating mocks, fixtures, and tests.
82%
#1949 repo: silence deb caching when fetching packages snapcraft merged Merged PR #1949 as commit 54323e13b, locally reimplementing fetch_binary to suppress deb-cache output. PR #3009 later replaced it with python-apt's implementation.
74%
#2808 repo: fix fetch_binary()'s return type for deb repo snapcraft merged Merged #2808 (commit 638740ae1) corrected the deb repository's fetch_binary() return annotation to its string path result, fixing mypy upgrade errors.
72%