← Back to issue list

fix: do not propagate build-base to snap.yaml

View original Github issue

Metadata

Project
snapcraft
Number
#4580
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4580 (d4e948f33), preventing build-base from being propagated into generated snap.yaml files.

Resolution: closed resolved

Reason: The approved change was merged as commit d4e948f33, fixing snap manifest generation so build-base is excluded from snap.yaml.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4580 (d4e948f33), preventing build-base from being propagated into generated snap.yaml files.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#4580 via commit d4e948f33, preventing build-base from being propagated to snap.yaml.
qwen/qwen3.6-35b-a3b — — Merged a fix preventing build-base from propagating to snap.yaml. The pull request received two approvals, passed CI checks and code coverage, and was successfully integrated.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix preventing build-base from propagating to snap.yaml. The change passed all tests with full coverage on modified lines and was successfully integrated by the maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6499 fix: parse build-base for snapcraftctl validation snapcraft merged Fixed a validator bug preventing core22/core24 snaps without a `base` key from using `snapcraftctl`. Merged as #6499, resolving #6336.
75%
#3014 meta: migrate get_build_base to Snap snapcraft merged Merged in snapcraft#3014 via commit 09be6bb53, moving get_build_base from Projectinfo to Snap and simplifying tests to use Snap metadata instead of self.project.info.
74%
#6426 feat: add build-base to kernel snaps snapcraft closed Merged PR #6426 (commit dd924c747), adding build-base to kernel snap metadata so users can verify build-environment and target-system compatibility.
74%
#2689 schema: build-base support for the snapd type snapcraft merged Merged PR #2689 added schema support for using build-base with snapd and base snap types.
71%
#5388 fix: don't fail when checking the base snapcraft merged Merged PR #5388 in commit 5c43d861c, deferring base-check failures so invalid base definitions reach Snapcraft's user-friendly validation errors (SNAPCRAFT-313).
71%
#2309 snap: improve early base detection logic snapcraft merged Merged PR #2309 (commit 3565ed2e7), fixing early base detection when Snapcraft runs in a build provider outside the project directory (LP #1795501).
71%
#4868 Allow specifying build-base in kernel snap snapcraft closed Kernel snaps gained configurable build-base support; merged PR #4914 fixed #4868 by adding interim kernel-snap bases and cross-craft-name documentation.
70%
#3721 meta: fix snap yaml generation to match legacy snapcraft merged Merged PR #3721 via e2bfca89d, aligning generated snap YAML with legacy by declaring the snap type and emitting an empty apps list when no apps exist.
70%