fix: do not propagate build-base to snap.yaml
Metadata
Current evaluation
Merged a fix preventing build-base from propagating to snap.yaml. The pull request received two approvals, passed CI checks and code coverage, and was successfully integrated.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix preventing build-base from propagating to snap.yaml. The pull request received two approvals, passed CI checks and code coverage, and was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing build-base from propagating to snap.yaml. The change passed all tests with full coverage on modified lines and was successfully integrated by the maintainer. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing build-base propagation to snap.yaml. The change passed code coverage checks and was integrated into the repository by maintainer sergiusens. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2689 schema: build-base support for the snapd type | snapcraft | merged | Merged into master. Implements build-base keyword support for the snapd snap type, enabling its construction. Approved by reviewer, passed CI, and updated four files. | |
| #2309 snap: improve early base detection logic | snapcraft | merged | Merged. Resolved early base detection failure in build providers by updating logic to account for snapcraft's non-project directory execution. Approved by reviewer, passed CI, and merged with minimal changes. | |
| #5388 fix: don't fail when checking the base | snapcraft | merged | Merged a fix preventing snapcraft from failing early during base checks. Enables user-friendly error reporting for incorrect bases. Approved by two reviewers and merged with 10 additions and 30 deletions across three files. | |
| #3014 meta: migrate get_build_base to Snap | snapcraft | merged | Merged after approval and passing CI. Migrated get_build_base from Projectinfo to Snap, simplifying test fixtures and removing plugin dependencies on self.project.info across 61 files. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change. | |
| #3959 meta: fix snap.yaml app slots | snapcraft | merged | Merged a pull request adding missing app slots to snap.yaml. Approved by a reviewer, passed CI checks, and successfully integrated into the repository. | |
| #3836 snapcraft/meta: make Manifest.base optional | snapcraft | merged | Merged a fix making Manifest.base optional to resolve a validation error crashing manifest generation for core22 base snaps. Approved and merged after passing CI. Reviewers suggested adding a spread test for base building cases. | |
| #1004 fix: unhelpful error message when `base` is missing from YAML | rockcraft | merged | Merged a fix that improves the error message when the base field is missing from YAML, resolving issue 997. Approved by two reviewers, the PR passed CI checks aside from unrelated known failures, and was successfully integrated. | |
| #3729 parts: handle build base | snapcraft | merged | Merged into snapcraft/7.0. Implements build-base handling for parts, configuring the correct build environment by using the declared build-base or falling back to the package name for base-type projects. Approved and passed CI. |