pluginhandler: deterministic load depending on plugin and build-base
Metadata
Current evaluation
Merged after reviewer approval and passing CI. Replaced unreliable local plugin loading with a deterministic factory that selects pre-imported plugins based on the build-base. Refactored code across 15 files.
Suggested action: —
No scores available.
Issue body
- General code clean up.
- Remove poor local plugin loading logic (x- no x-).
- Use a "factory" to return the pre-imported plugins depending on the
- build-base.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI. Replaced unreliable local plugin loading with a deterministic factory that selects pre-imported plugins based on the build-base. Refactored code across 15 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor replacing inconsistent local plugin loading with a deterministic factory-based approach that selects pre-imported plugins by build-base. Includes general code cleanup to improve reliability. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor replacing inconsistent local plugin loading with a deterministic factory-based approach. The change selects pre-imported plugins based on the build-base and includes general code cleanup. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2329 pluginhandler: remove legacy plugin loading without project | snapcraft | merged | Merged pull request removing legacy plugin loading logic without project support, aligning with the move to bases. Approved by maintainer, passed CI, and successfully integrated into the codebase. |