tests: remove usage of FakeApt fixtures in lifecycle
Metadata
Current evaluation
Merged PR #3024 in commit ab892ee03, replacing lifecycle tests' FakeApt fixtures with targeted mock patches and related cleanup.
Resolution: closed resolved
Reason: PR #3024 was approved and merged as commit ab892ee03, completing the lifecycle-test cleanup with targeted mock patches.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Use a couple targetted mock.patches to provide equivalent
functionality. Some related cleanup included.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3024 in commit ab892ee03, replacing lifecycle tests' FakeApt fixtures with targeted mock patches and related cleanup. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3024 (ab892ee03) replaced lifecycle tests' FakeApt fixtures with targeted mock patches and related test cleanup. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes replacing FakeApt fixtures in lifecycle tests with targeted mock.patch calls and related cleanup. Approved by one reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Replaced FakeApt fixtures in lifecycle tests with targeted mock.patch calls to maintain equivalent functionality, alongside related test cleanup. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3025
(confidence 99%)
Follow-up PR #3025, commit 1237aa677, moved the remaining FakeApt fixtures into deb tests.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3025 tests: move FakeApt fixtures into deb tests | snapcraft | merged | Merged PR #3025 in commit 1237aa6, moving FakeApt fixtures from shared test support into the DEB tests after #3024 removed the remaining external uses. | |
| #831 Fixed/simplified some tests to isolate them of underlying apt. | charmcraft | merged | Merged PR #831 removed apt-dependent execution from parts/build tests, replacing a null plugin and simplifying build fixtures; merged as commit 6418a586. | |
| #1334 tests: use the fake apt cache in deb unit tests | snapcraft | merged | Merged PR #1334 as commit 3bcb730e0, updating deb unit tests to use a fake APT cache for better isolation and reliability. | |
| #3719 tests: fix lifecycle tests to run on new directory | snapcraft | merged | Merged PR #3719 via commit 314dd7574 to run lifecycle tests in a new directory instead of the current directory. | |
| #2057 tests: extract lifecycle suite from general suite | snapcraft | merged | Merged PR #2057 as commit 59bdc3343, splitting lifecycle tests from the oversized general suite to prevent Travis timeouts. |