tests: move FakeApt fixtures into deb tests
Metadata
Current evaluation
Merged PR #3025 in commit 1237aa6, moving FakeApt fixtures from shared test support into the DEB tests after #3024 removed the remaining external uses.
Resolution: closed resolved
Reason: The approved PR was merged as commit 1237aa6, relocating the fixtures to test_deb now that they were no longer shared.
Evaluated by: mr-cal-bot
No scores available.
Issue body
These are no longer shared for other tests so we can freely
modify without breaking external tests. We'll move them
into test_deb to discourage further external use.
Depends on #3024
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3025 in commit 1237aa6, moving FakeApt fixtures from shared test support into the DEB tests after #3024 removed the remaining external uses. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3025 in commit 1237aa6, moving FakeApt fixtures from shared test support into deb-only tests after lifecycle usage was removed in #3024. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3025 (commit 1237aa6) moved FakeApt fixtures from shared test support into test_deb, completing the cleanup prepared by #3024. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to relocate FakeApt test fixtures into the deb test suite, eliminating external dependencies and enabling safe modifications. Approved by a reviewer, passed CI, and modified three files with a net reduction of four lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by cjp256. Relocated FakeApt test fixtures into the deb test suite to prevent breaking external tests and discourage outside usage. Requires PR #3024. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#3024
(confidence 100%)
Prerequisite PR that removed lifecycle tests' external use of the FakeApt fixtures and enabled their relocation.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1334 tests: use the fake apt cache in deb unit tests | snapcraft | merged | Merged PR #1334 as commit 3bcb730e0, updating deb unit tests to use a fake APT cache for better isolation and reliability. | |
| #3024 tests: remove usage of FakeApt fixtures in lifecycle | snapcraft | merged | Merged PR #3024 in commit ab892ee03, replacing lifecycle tests' FakeApt fixtures with targeted mock patches and related cleanup. | |
| #831 Fixed/simplified some tests to isolate them of underlying apt. | charmcraft | merged | Merged PR #831 removed apt-dependent execution from parts/build tests, replacing a null plugin and simplifying build fixtures; merged as commit 6418a586. | |
| #563 fix(tests): replace ineffective call assertions | craft-parts | merged | Merged PR #563 (commit 18458997) replaced ineffective assert_has_calls checks with mock_calls equality assertions in packages.deb tests, fixing #368. |