← Back to issue list

tests: move FakeApt fixtures into deb tests

View original Github issue

Metadata

Project
snapcraft
Number
#3025
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged to relocate FakeApt test fixtures into the deb test suite, eliminating external dependencies and enabling safe modifications. Approved by a reviewer, passed CI, and modified three files with a net reduction of four lines.

Suggested action:

No scores available.

Issue body

These are no longer shared for other tests so we can freely modify without breaking external tests. We'll move them into test_deb to discourage further external use. Depends on #3024

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to relocate FakeApt test fixtures into the deb test suite, eliminating external dependencies and enabling safe modifications. Approved by a reviewer, passed CI, and modified three files with a net reduction of four lines.
qwen3.6-35b-a3b-mtp-q6 Merged by cjp256. Relocated FakeApt test fixtures into the deb test suite to prevent breaking external tests and discourage outside usage. Requires PR #3024.
qwen3.6-35b-a3b-mtp-q6 Merged changes that move FakeApt test fixtures into the deb test suite, preventing external test breakage and discouraging outside usage. Depends on #3024.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1334 tests: use the fake apt cache in deb unit tests snapcraft merged Merged implementation of a fake apt cache for deb unit tests. The update modifies two files (+87/-44 lines) and was approved by two reviewers, improving test isolation and reliability.
82%
#3024 tests: remove usage of FakeApt fixtures in lifecycle snapcraft merged Merged changes replacing FakeApt fixtures in lifecycle tests with targeted mock.patch calls and related cleanup. Approved by one reviewer and passed CI checks.
82%
#46 tests: add fake snapd fixture craft-parts merged Merged after two approvals and passing CI. Introduces a fake snapd fixture to test snap package handling in craft-parts.packages. Adds 212 lines across two files. Windows compatibility limitations were noted for separate follow-up.
70%
#831 Fixed/simplified some tests to isolate them of underlying apt. charmcraft merged Merged test refactoring that isolates three tests from external apt dependencies. Replaced a charm plugin with a null plugin, removed a flawed integration test, and improved project setup for a linter test. CI passed.
70%