This does remove the broken dependency handling... I need a working test case to make sure that's solid. - Move repo.get_pkg_name_parts to test_base, even though it's in __init__. - Remove all instance methods from repo and Ubuntu, consolidating to install_stage_packages() classmethod. - Move non-class methods in Repo into Repo class so they can be easily inherited. - Remove custom _AptCache implementation. - Use a single instance of the system's apt cache, which should improve performance due to the penalty of recreating caches in numerous points. It also simplifies usage without the requirement of copying/sharing instances for what is (now) a system-wide resource. - Remove old scheme for gathering stage packages, and simply do a scan ourselves for the packages and their dependencies. Then fetch them using python-apt's fetch_binary(). - Rework apt tests. - Rework of the ROS plugins to remove their current usage of Ubuntu and replace it with install_stage_packages(). Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----