repos: fix returned strings for install_stage_packages()
Metadata
Current evaluation
Merged PR #3047 in commit 2e6549953, fixing install_stage_packages() to return resolved package version strings and adding unit coverage.
Resolution: closed resolved
Reason: PR #3047 was merged as commit 2e6549953. The change converts apt.Version values into the intended package=version strings and updates unit tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Instead of returning `<package>=<version>`, it was returning
`<package>=<apt.Version>`. Resolve the version string which
is the intended return value.
Fix unit tests to cover this. Switch to using PropertyMocks,
as the MagicMock(wraps=...) did not work as I had expected.
LP #1873349
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3047 in commit 2e6549953, fixing install_stage_packages() to return resolved package version strings and adding unit coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3047 (commit 2e6549953), fixing install_stage_packages() to return resolved version strings and adding unit-test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #3047 (commit 2e6549953), fixing install_stage_packages() to return resolved version strings and adding unit-test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3047 fixed install_stage_packages() to return resolved package version strings instead of apt.Version objects, with PropertyMocks unit tests for LP #1873349. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for install_stage_packages() to return resolved version strings instead of raw apt.Version objects. Updated unit tests to use PropertyMocks. Resolves LP #1873349. Approved by one reviewer with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix correcting install_stage_packages() to return resolved version strings instead of apt.Version objects. Updated unit tests using PropertyMocks and resolves LP #1873349. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3035 repo: fix resolution of virtual build packages | snapcraft | merged | Merged PR #3035 in commit 9e9290554, restoring virtual build-package resolution, preserving versions, logging resolved packages, and adding unit and spread tests. |