repo: fix resolution of virtual build packages
Metadata
Current evaluation
Merged fix for virtual build package resolution regression. Ensures proper resolution and versioning persistence for build and stage packages, adds logging, and includes unit and spread tests. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
With my previous PR, virtual build packages are no longer found.
Ensure that build and stage packages are resolved the best we can,
and persist any potential versioning.
Log any build and stage packages that have been resolved so the
user can see any assumptions we're making to resolve it.
Add unit and spread test coverage.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for virtual build package resolution regression. Ensures proper resolution and versioning persistence for build and stage packages, adds logging, and includes unit and spread tests. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for virtual build package resolution. Ensures build and stage packages are properly resolved with version persistence, logs assumptions, and adds unit and spread test coverage. Initially noted a dependency on PR #3036. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for virtual build package resolution. Ensures build and stage packages are resolved with persisted versioning, logs assumptions, and adds test coverage. Addressed dependency on PR #3036 prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3084 repo: fix for multi-arch virtual-packages | snapcraft | merged | Merged fix for multi-arch virtual package resolution. Correctly handles architecture tags, reverts or_dependencies to target_versions, and fixes an apt.Package.architectures method call. Approved and passed CI. | |
| #3221 repo: install requested build-package versions | snapcraft | merged | Merged fix for unimplemented build-package version installation. Explicitly specifies apt package versions and enables downgrades to resolve LP: #1887960. Approved and passed CI checks. | |
| #3047 repos: fix returned strings for install_stage_packages() | snapcraft | merged | Merged fix for install_stage_packages() to return resolved version strings instead of raw apt.Version objects. Updated unit tests to use PropertyMocks. Resolves LP #1873349. Approved by one reviewer with passing CI checks. | |
| #1185 repo: add version support for build-packages | snapcraft | merged | Merged after adjusting apt_cache to exclude package versions, adding version support for build-packages. Rebased changes were re-applied and tests passed. Approved by two reviewers. | |
| #2023 repo: catch error due to broken build packages | snapcraft | merged | Resolved broken build package errors by introducing BuildPackagesNotInstalledError and falling back to apt-get for detailed conflict messages. Merged after reviewer approval and passing CI checks. | |
| #234 executor: fix update build stage packages | craft-parts | merged | Merged a fix for build stage package update consistency and resolved unpacked files disappearing after build updates. Approved by two reviewers, passed CI, and integrated with 49 additions and 26 deletions across five files. |