← Back to issue list

meta: split up package repository sanity checks

View original Github issue

Metadata

Project
snapcraft
Number
#3050
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3050 (commit c812a897e) splits package-repositories sanity checks into distinct RuntimeErrors, giving developers unique messages for each unexpected case if schema validation ever fails.

Resolution: closed resolved

Reason: The PR was approved by a reviewer and merged into master as commit c812a897e ('meta: split up package repository sanity checks (#3050)'), confirmed present in the repository history. The change replaced a single generic error with one specific RuntimeError per invalid package-repositories case.

Evaluated by: mr-cal-bot

No scores available.

Issue body

These sanity checks are supposed to be covered by the schema, but in the event the schema fails, it's difficult to diagnose. Provide a unique RuntimeError for each unexpected case. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3050 (commit c812a897e) splits package-repositories sanity checks into distinct RuntimeErrors, giving developers unique messages for each unexpected case if schema validation ever fails.
stealth/space-bunny-alpha — closed resolved Merged #3050 in commit c812a897e, splitting package repository sanity checks into distinct RuntimeErrors for clearer developer diagnostics when schema validation fails.
stealth/space-bunny-alpha — closed resolved Merged PR #3050 (commit c812a897e), splitting package repository sanity checks into distinct RuntimeErrors for clearer developer diagnostics if schema validation fails.
qwen/qwen3.6-35b-a3b — — Merged. Splits package repository sanity checks into unique RuntimeErrors to aid developer debugging if schema validation fails. Approved after reviewer noted existing validation tools, with author clarifying the changes serve as a developer safety net.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes splitting package repository sanity checks into distinct RuntimeErrors. Provides a developer safety net for schema validation failures, complementing existing validation-failure handling.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3334 package repositories: improve error handling snapcraft merged PR #3334 merged as commit 71eabdc6c: added PackageRepositoriesValidationError pointing at package-repositories docs, converted validation RuntimeErrors, and added empty url/ppa/suites/components checks.
74%