← Back to issue list

package repositories: improve error handling

View original Github issue

Metadata

Project
snapcraft
Number
#3334
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

PR #3334 merged as commit 71eabdc6c: added PackageRepositoriesValidationError pointing at package-repositories docs, converted validation RuntimeErrors, and added empty url/ppa/suites/components checks.

Resolution: closed resolved

Reason: The PR was merged into snapcraft as commit 71eabdc6c ("package repositories: improve error handling (#3334)"), confirmed by the git log entry and issue metadata showing state merged with approved review. The change introduces PackageRepositoriesValidationError and converts package-repository validation RuntimeErrors, plus trivial empty url/ppa/suites/components checks.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- Create PackageRepositoriesValidationError for errors pointing user to documentation page for package-repositories. - Convert all validation RuntimeErrors to PackageRepositoriesValidationError. - Add some trivial checks/handling for empty string url and ppa. - Add trivial check for empty suites/components. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3334 merged as commit 71eabdc6c: added PackageRepositoriesValidationError pointing at package-repositories docs, converted validation RuntimeErrors, and added empty url/ppa/suites/components checks.
stealth/space-bunny-alpha — closed resolved Merged PR #3334 (71eabdc6c), adding PackageRepositoriesValidationError and checks for empty URLs, PPAs, suites, and components.
qwen/qwen3.6-35b-a3b — — Improves package repository error handling by introducing PackageRepositoriesValidationError to replace generic RuntimeErrors. Adds checks for empty URLs, PPAs, suites, and components. Approved and merged after passing CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged package repository error handling improvements. Replaced generic RuntimeErrors with PackageRepositoriesValidationError, added empty string checks for URLs, PPAs, suites, and components, and refactored validation across initialization, unmarshaling, and a dedicated validate method.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3336 (confidence 45%)

    Adjacent package-repositories PR (104c6a807) introducing path property for exact paths, landed right after this one.

  • Related To: canonical/snapcraft#3333 (confidence 40%)

    Adjacent finalization of the package repositories spec (23d2ca056) preceding this error-handling work.

Related issues

Issue Project State Summary Similarity
#3050 meta: split up package repository sanity checks snapcraft merged Merged PR #3050 (commit c812a897e) splits package-repositories sanity checks into distinct RuntimeErrors, giving developers unique messages for each unexpected case if schema validation ever fails.
74%
#3276 meta: add suite/component validation checks for package-repositories snapcraft closed PR #3276 was closed unmerged after more than six years without review, CI, comments, or a recorded replacement; no resolving commit was identified.
72%
#3072 schema: minor tweaks/fixes for package-repositories snapcraft merged Merged #3072 as d2c0efe09, refining package-repositories validation, optional names, empty-field coverage, and missing-URL test behavior.
72%