← Back to issue list

cmake v2 plugin: rename configflags to cmake-parameters

View original Github issue

Metadata

Project
snapcraft
Number
#3064
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged. Renamed configflags to cmake-parameters in the cmake plugin to correctly namespace the property and remove ambiguity. Updated spread test accordingly.

Suggested action: —

No scores available.

Issue body

This correctly namespaces the property to the cmake plugin removing any ambiguity on what processes it. Additionally make the spread test use the cmake-parameter property. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. Renamed configflags to cmake-parameters in the cmake plugin to correctly namespace the property and remove ambiguity. Updated spread test accordingly.
qwen3.6-35b-a3b-mtp-q6 — — Merged a rename of the cmake v2 plugin property from configflags to cmake-parameters to properly namespace the setting and eliminate ambiguity. The associated spread test was updated to reflect the change.
qwen3.6-35b-a3b-mtp-q6 — — Merged a change renaming the cmake v2 plugin's configflags property to cmake-parameters for proper namespacing. Updated the spread test to use the new property, eliminating process ambiguity.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3066 autotools v2 plugin: rename configflags to autotools-configure-parame… snapcraft merged Merged a maintainer change renaming configflags to autotools-configure-parameters in the autotools v2 plugin. This correctly namespaces the property to eliminate ambiguity. All checks passed and the code was integrated.
73%