← Back to issue list

cmake v2 plugin: rename configflags to cmake-parameters

View original Github issue

Metadata

Project
snapcraft
Number
#3064
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 8168c467a: the CMake v2 plugin's `configflags` property was renamed to the namespaced `cmake-parameters`, and the spread test was updated to use it.

Resolution: closed resolved

Reason: The PR itself is the resolution and was merged into master as commit 8168c467a, which renamed the property in the v2 CMake plugin and updated the corresponding spread test. The name persists today (used in snap/snapcraft.yaml and the multipass valid_projects fixture).

Evaluated by: mr-cal-bot

No scores available.

Issue body

This correctly namespaces the property to the cmake plugin removing any ambiguity on what processes it. Additionally make the spread test use the cmake-parameter property. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 8168c467a: the CMake v2 plugin's `configflags` property was renamed to the namespaced `cmake-parameters`, and the spread test was updated to use it.
stealth/space-bunny-alpha — closed resolved Merged PR #3064 renamed the CMake v2 plugin property from configflags to cmake-parameters and updated the spread test; merged as commit 8168c467a.
stealth/space-bunny-alpha — closed resolved Merged PR #3064 renamed CMake v2's configflags property to cmake-parameters, eliminating ambiguity and updating the spread test to use the new name.
qwen/qwen3.6-35b-a3b — — Merged. Renamed configflags to cmake-parameters in the cmake plugin to correctly namespace the property and remove ambiguity. Updated spread test accordingly.
qwen3.6-35b-a3b-mtp-q6 — — Merged a rename of the cmake v2 plugin property from configflags to cmake-parameters to properly namespace the setting and eliminate ambiguity. The associated spread test was updated to reflect the change.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3066 (confidence 92%)

    Sibling merged PR (commit 75dd96faa) doing the same rename for the autotools v2 plugin, to autotools-configure-parameters

  • Caused By: canonical/snapcraft#3037 (confidence 55%)

    Commit 4efb119ee introduced the v2 CMake plugin initially using configflags, prompting the namespacing fix

Related issues

Issue Project State Summary Similarity
#3066 autotools v2 plugin: rename configflags to autotools-configure-parame… snapcraft merged Merged as commit 75dd96faa, renaming the autotools v2 plugin property from configflags to autotools-configure-parameters to clearly namespace it.
73%