← Back to issue list

plugins: introduce v2.CMakePlugin

View original Github issue

Metadata

Project
snapcraft
Number
#3037
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged introduction of v2.CMakePlugin and consolidation of the v2 plugin spread test suite to streamline future development. Approved by one reviewer, passed CI, and modified 16 files with 196 additions and 23 deletions.

Suggested action:

No scores available.

Issue body

Clean up the spread suite for v2 plugins to ease development of new plugins (the suite has been consolidated into one). Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged introduction of v2.CMakePlugin and consolidation of the v2 plugin spread test suite to streamline future development. Approved by one reviewer, passed CI, and modified 16 files with 196 additions and 23 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged v2.CMakePlugin introduction. Consolidated the v2 plugin spread test suite into a single file to streamline future plugin development.
qwen3.6-35b-a3b-mtp-q6 Merged. Introduces v2.CMakePlugin and consolidates the v2 plugin spread test suite to streamline future development.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3032 plugins: introduce v2.MakePlugin with rebuilding snapcraft merged Merged introduction of v2.MakePlugin with rebuilding support and proper environment setup. Approved by one reviewer, the change updates 23 files (+379/-92 lines).
78%
#3268 v2 plugins: add catkin plugin snapcraft merged Merged after passing review and CI checks. Introduced a new Catkin plugin using the v2 plugin API and refactored shared code from the Colcon plugin. Additional spread tests were added to verify all plugin options.
76%
#3059 plugins: introduce v2.MesonPlugin snapcraft merged The v2.MesonPlugin feature was approved by one reviewer and successfully merged. The commit added 216 lines and removed 4 across 10 files, finalizing the new plugin implementation.
76%
#713 feat(docs): cmake plugin reference craft-parts merged Merged addition of a CMake plugin reference to the documentation. Approved by two reviewers with passing CI checks, modifying two files with 87 additions and 87 deletions.
75%
#935 cmake plugin: utilize MakePlugin build logic within CMakePlugin snapcraft merged Merged. Refactors MakePlugin build logic into a reusable method, allowing CMakePlugin to leverage existing customization. Approved by two reviewers, modified four files (+51/-31 lines), and added tests for the optional env parameter.
75%
#2183 tests: add spread suite for cmake plugin snapcraft merged Merged into master, resolving LP #1783830 by migrating CMake plugin integration tests to a Spread suite. Approved, passed CI, and maintained 91.23% code coverage across 17 modified files.
74%
#33 plugins: add make plugin craft-parts merged Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system.
74%
#184 plugins: cmake craft-parts merged Merged the cmake plugin port to craft-parts following approval from two reviewers and passing CI checks. The maintainer addressed review feedback regarding leftover code prior to integration.
74%
#3061 plugins: introduce v2.RustPlugin snapcraft merged Merged introduction of v2.RustPlugin to the plugins module. Approved by one reviewer. Updated 26 files with 275 additions and 76 deletions, successfully integrating the new Rust plugin version into the codebase.
74%
#3070 plugins v2: update plugins so they have a similar behavior snapcraft merged Merged after reviewer approval and passing CI. Standardized plugin behavior by removing invalid minitems usage, eliminating prefix setup and default build type concepts, and correcting docstring formatting across 13 files.
74%