pluginhandler: run plugin commands in isolation
Metadata
Current evaluation
Merged updates to execute plugin commands in isolation, enhancing error reporting and matching PluginV1 behavior. Resolves SNAPCRAFT-1NQ following successful review and CI validation.
Suggested action: —
No scores available.
Issue body
Iterate over plugin commands and run them in isolation. This allows
clearer error reporting. The same exception as in PluginV1 is raised on
command execution.
Fixes SNAPCRAFT-1NQ
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to execute plugin commands in isolation, enhancing error reporting and matching PluginV1 behavior. Resolves SNAPCRAFT-1NQ following successful review and CI validation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged implementation to execute plugin commands in isolation, improving error reporting and aligning with PluginV1 exception handling. Resolves SNAPCRAFT-1NQ. Review noted minor shell evaluation constraints, but the change was accepted and integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to run plugin commands in isolation, improving error reporting and fixing SNAPCRAFT-1NQ. The maintainer implemented isolated execution after acknowledging previous constraints. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3317 plugin handler: properly handle snapcraftctl errors | snapcraft | merged | Merged fix for plugin handler to properly catch snapcraftctl errors. Replaced specific exception handling with a broad catch in the scriptlet runner to prevent silent failures and redundant output. Approved, passed CI, and increased coverage. | |
| #3077 pluginhandler: skip plugin clean_pull for PluginV2 | snapcraft | merged | Merged. Updated unit tests to skip plugin clean_pull for PluginV2 as the method no longer exists, fixing SNAPCRAFT-1JS. |