← Back to issue list

pluginhandler: run plugin commands in isolation

View original Github issue

Metadata

Project
snapcraft
Number
#3139
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#3139 (389c180ea), running PluginV2 commands independently for clearer errors and PluginV1-equivalent execution exceptions; fixes SNAPCRAFT-1NQ.

Resolution: closed resolved

Reason: The approved PR was merged as commit 389c180ea, isolating PluginV2 command execution and aligning command-failure exceptions with PluginV1 behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Iterate over plugin commands and run them in isolation. This allows clearer error reporting. The same exception as in PluginV1 is raised on command execution. Fixes SNAPCRAFT-1NQ Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#3139 (389c180ea), running PluginV2 commands independently for clearer errors and PluginV1-equivalent execution exceptions; fixes SNAPCRAFT-1NQ.
stealth/space-bunny-alpha — closed resolved Merged #3139 in commit 389c180ea, making PluginV2 run commands independently, improving error reporting and matching PluginV1's command-execution exception behavior.
stealth/space-bunny-alpha — closed resolved Merged #3139 (commit 389c180ea) to run PluginV2 commands independently, improve error reporting, and match PluginV1’s execution exception behavior; fixes SNAPCRAFT-1NQ.
stealth/space-bunny-alpha — closed resolved Merged PR #3139 in commit 389c180ea, isolating plugin commands for clearer error reporting and PluginV1-compatible exception handling.
qwen/qwen3.6-35b-a3b — — Merged updates to execute plugin commands in isolation, enhancing error reporting and matching PluginV1 behavior. Resolves SNAPCRAFT-1NQ following successful review and CI validation.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation to execute plugin commands in isolation, improving error reporting and aligning with PluginV1 exception handling. Resolves SNAPCRAFT-1NQ. Review noted minor shell evaluation constraints, but the change was accepted and integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3131 plugin handler: debug build commands if developer debug enabled snapcraft closed Closed unmerged as superseded by snapcraft#3139, which merged isolated PluginV2 command execution and clearer error reporting in commit 389c180ea.
80%
#3077 pluginhandler: skip plugin clean_pull for PluginV2 snapcraft merged Merged in snapcraft#3077 (commit 167cc98ec), skipping PluginV2 clean_pull calls and updating unit tests because the method no longer exists; fixes SNAPCRAFT-1JS.
73%