meta: remove snapd workaround for classic for core20 onwards
Metadata
Current evaluation
Merged canonical/snapcraft#3087 as commit 244b997ca, removing the automatic classic snapcraft-runner workaround for core20 and newer while retaining it for legacy bases.
Resolution: closed resolved
Reason: PR #3087 was approved and merged in commit 244b997ca. It stopped injecting snapcraft-runner command chains for classic apps on core20+, while preserving compatibility for core, core16, core18, and the no-base/build-base case.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Keep the command-chain workaround for core, core16, core18 and the
case of no base (when used with build-base).
All other bases should follow user instruction and have no
command-chain if not specifically requested when using classic
confinement.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#3087 as commit 244b997ca, removing the automatic classic snapcraft-runner workaround for core20 and newer while retaining it for legacy bases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3087 in commit 244b997ca, removing snapd's automatic classic command-chain workaround for core20+ while retaining it for legacy and no-base builds. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3087 (commit 244b997ca): removed the snapd classic-confinement command-chain workaround for core20 and later, while retaining it for core, core16, core18, and no-base builds. | |
| qwen/qwen3.6-35b-a3b | — | — | Removed snapd classic confinement workaround for core20 and newer bases. Retained command-chain workaround for core, core16, core18, and no base. Merged after single reviewer approval and passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removes the snapd command-chain workaround for classic confinement on core20 and newer bases, preserving it for core, core16, core18, and no-base scenarios. Aligns behavior with standard user instructions. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#2889
(confidence 98%)
That earlier PR introduced the always-generated snapcraft-runner workaround removed for core20+.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2891 meta: always generate snapcraft-runner to workaround classic (#2889) | snapcraft | merged | Merged in PR #2891 as commit 343ac2862, adding an empty snapcraft-runner command-chain workaround for classic apps with incorrect PATH handling and unit tests. | |
| #2889 meta: always generate snapcraft-runner to workaround classic PATH bug | snapcraft | merged | Merged #2889 as commit 343ac2862, always adding an empty snapcraft-runner to app command chains to work around incorrect PATH in non-shell classic apps. | |
| #3579 snap: move base to core20 (CRAFT-509) | snapcraft | merged | Merged PR #3579 via ed2baf8bd, moving Snapcraft's own snap to the core20 base; implementation commit 18a974e01. | |
| #1647699 Support classic building in snapcraft | snapcraft (launchpad) | closed | Classic-snap builds were implemented by merged snapcore/snapcraft#949 (commit 058f5626d), resolving libraries from the core/base snap. | |
| #949 project: support building classic snaps | snapcraft | merged | Merged PR #949 in commit 058f5626d, adding classic-snap build support and core-snap path configuration. | |
| #2285 snapcraft snap: vendor legacy snapcraft | snapcraft | merged | Merged in canonical/snapcraft#2285 (commit 5c1ee3b88), vendoring legacy Snapcraft and dispatching no-base projects to it to preserve backward compatibility. | |
| #4118 init: use core22 base for `snapcraft init` | snapcraft | merged | Merged PR #4118 (mr-cal, CRAFT-1670): snapcraft init now scaffolds core22 as the default base instead of core20, with the command moved from snapcraft_legacy/ to snapcraft/ and a spread test added. Squash-merged as 4afc9e4c9. | |
| #1170 core: fix symlink resolution in get_core_dynamic_linker | snapcraft | merged | Merged canonical/snapcraft#1170 as commit b19e9cf68, fixing relative symlink resolution in get_core_dynamic_linker so classic snap builds work on affected architectures. | |
| #4807 fix: do not load system libraries for classic core24 snaps | snapcraft | closed | PR #4807 was closed in favor of #4809, which merged commit 5493a5f91 and shipped in Snapcraft 8.2.8; classic core24 snaps now use patchelf --no-default-libs. | |
| #5694 fix(backport): remove unnecessary snapd_snap flag (#5689) | snapcraft | merged | Merged backport #5694 (cb5283b6a) removed obsolete snapd_snap handling for Snapcraft 7.5, fixing core20 repacking failure #5316; original fix was #5689. |