← Back to issue list

meta: remove snapd workaround for classic for core20 onwards

View original Github issue

Metadata

Project
snapcraft
Number
#3087
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Removed snapd classic confinement workaround for core20 and newer bases. Retained command-chain workaround for core, core16, core18, and no base. Merged after single reviewer approval and passing CI checks.

Suggested action:

No scores available.

Issue body

Keep the command-chain workaround for core, core16, core18 and the case of no base (when used with build-base). All other bases should follow user instruction and have no command-chain if not specifically requested when using classic confinement. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Removed snapd classic confinement workaround for core20 and newer bases. Retained command-chain workaround for core, core16, core18, and no base. Merged after single reviewer approval and passing CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Removes the snapd command-chain workaround for classic confinement on core20 and newer bases, preserving it for core, core16, core18, and no-base scenarios. Aligns behavior with standard user instructions.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the snapd command-chain workaround for classic confinement on core20 and later bases, retaining it only for core, core16, core18, and unconfigured bases.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1112 core: setup core to support classic confinement. snapcraft merged Merged after CI fixes and reviewer approval. Introduces SNAPCRAFT_SETUP_CORE environment variable support to manually unpack the core snap, enabling classic confinement on systems lacking /snap/core/current.
73%
#2261 build providers: inject the base for classic snapcraft merged Successfully merged pull request that injects the base snap for classic confinement to configure appropriate linker paths during builds. Approved by two reviewers and passed CI checks.
72%
#3579 snap: move base to core20 (CRAFT-509) snapcraft merged Merged updates the snap base to core20. Approved by two reviewers with passing CI checks. Changes affect 13 files, increase coverage by 0.07%, and update initialization templates to core20.
72%
#4763 tests: remove core24 snap workarounds (#4761) snapcraft merged Merged into main after two approvals and passing CI. The change cherry-picks test updates to remove core24 snap workarounds, resolving CI failures by deleting 22 lines of legacy code in a single file.
72%
#4216 meta: omit LD_LIBRARY_PATH and PATH in classic confinement snapcraft merged Merged to omit default LD_LIBRARY_PATH and PATH in classic confinement, resolving #4187. Post-merge comments warn the change may break existing classic snaps relying on the previous PATH behavior.
71%
#2891 meta: always generate snapcraft-runner to workaround classic (#2889) snapcraft merged Merged as #2889. Introduces an empty snapcraft-runner to the command-chain to fix incorrect PATH resolution for classic snap apps. Includes unit tests and configurable fixtures. Approved by reviewers and passed CI.
71%