snapcraft snap: vendor legacy snapcraft
Metadata
Current evaluation
Merged. Vendored legacy snapcraft into the snapcraft snap to resolve LP: #1793261, maintaining support when no base is specified in snapcraft.yaml. Approved by one reviewer and passed CI checks prior to integration.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
This PR resolves [LP: #1793261](https://bugs.launchpad.net/snapcraft/+bug/1793261), continuing support for the lack of a base by vendoring legacy snapcraft into the snapcraft snap and dispatching to it if there is no base specified in the snapcraft.yaml.
**Note:** These tests will fail until #2283 lands in legacy.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Vendored legacy snapcraft into the snapcraft snap to resolve LP: #1793261, maintaining support when no base is specified in snapcraft.yaml. Approved by one reviewer and passed CI checks prior to integration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Vendored legacy snapcraft into the snapcraft snap to resolve LP: #1793261, enabling fallback dispatch to the legacy version when snapcraft.yaml lacks a base specification. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Vendors legacy snapcraft into the snapcraft snap to dispatch to it when no base is specified in snapcraft.yaml, resolving LP: #1793261. Integration followed prerequisite PR #2283 landing in the legacy branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1793261 Vendor legacy snapcraft to maintain backward compatibility | snapcraft (launchpad) | closed | Closed without implementation. The proposal to vendor legacy snapcraft for backward compatibility was abandoned or superseded by newer architecture, receiving no further discussion or action. | |
| #3608 many: rename snapcraft package to snapcraft_legacy (CRAFT-726) | snapcraft | merged | Merged after renaming the snapcraft package to snapcraft_legacy to make room for a new craft libraries-based application. Approved, passed CI, and modified 557 files. The application entry point remains unchanged and will be handled separately. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). | |
| #2411 cli: snapcraft init with a base | snapcraft | merged | Merged. Adds a syntax documentation link after snapcraft init execution. Approved by one reviewer, passed CI checks, modified five files, and achieved 100% diff coverage. Resolves LP #1803776. | |
| #3616 cli: create new snapcraft entry point (CRAFT-729) | snapcraft | merged | Merged a new snapcraft CLI entry point that currently invokes the legacy implementation. This establishes the foundation for future routing logic between new and legacy code paths. | |
| #4090 snapcraft_legacy: inject current snapcraft snap into instances | snapcraft | merged | Merged into main. Injects the current snapcraft snap into build instances for core18 and core20 snaps. Approved by two reviewers, passed CI, and modified six files with 100% diff coverage. | |
| #1073 project: snapcraft.yaml in a snap directory | snapcraft | merged | Merged into master. Defaults new projects to place snapcraft.yaml inside a snap directory while retaining support for legacy locations. Approved and passed CI checks. | |
| #3683 commands: add snap command | snapcraft | merged | Merged into snapcraft/7.0. Implements legacy snap command support for package creation and fixes output parameter passing to managed instances. Approved by reviewer with passing CI checks. | |
| #2256 local source: don't include .snapcraft directory | snapcraft | merged | Resolved LP: #1791773 by merging a change that excludes the .snapcraft directory from copying and part staleness checks. Approved, passed CI, and merged with a six-line update across two files. |