pluginhandler: make the build environment available to all steps
Metadata
Current evaluation
Merged PR #3122 (commit f1f127136) refactoring pluginhandler so the build environment is available to all plugin steps, keeping build-environment limited to the build step. Fixes LP: #1876260.
Resolution: closed resolved
Reason: The PR was approved and merged into snapcraft as commit f1f127136, resolving LP bug #1876260. Reviewer cjp256's request to keep build-environment only on the build step was incorporated by the maintainer before merge.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1876260
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3122 (commit f1f127136) refactoring pluginhandler so the build environment is available to all plugin steps, keeping build-environment limited to the build step. Fixes LP: #1876260. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#3122 (commit f1f127136), making the build environment available to all plugin steps while keeping build-environment scoped to the build step. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Reviewer feedback refined scoping: build environment is now available across all plugin steps. SNAPCRAFT_STAGE stays global, build-environment stays on the build step. Changes affect 10 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Reviewer feedback refined the implementation to keep SNAPCRAFT_STAGE available globally while restricting build-environment to the build step only, aligning with project conventions. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3211
(confidence 40%)
Follow-up pluginhandler work on v2 plugin stage-snaps shortly after this change.
-
Related To:
snapcraft#3126
(confidence 35%)
Nearby pluginhandler cleanup (allow cleaning the build step) in the same area of the codebase.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3126 pluginhandler: allow cleaning the build step | snapcraft | merged | Merged PR #3126 as commit 2d331e010, fixing PluginV2 part cleanup by correcting the guard in clean_build so the build step can be cleaned. |