pluginhandler: allow cleaning the build step
Metadata
Current evaluation
Merged PR #3126 as commit 2d331e010, fixing PluginV2 part cleanup by correcting the guard in clean_build so the build step can be cleaned.
Resolution: closed resolved
Reason: The approved change corrected the improper clean_build guard that prevented PluginV2-based parts from cleaning their build step. It was merged in commit 2d331e010.
Evaluated by: mr-cal-bot
No scores available.
Issue body
PluginV2 based parts were not able to clean due to the improper guard
set at the start of the clean_build method.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3126 as commit 2d331e010, fixing PluginV2 part cleanup by correcting the guard in clean_build so the build step can be cleaned. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3126 as commit 2d331e010, fixing PluginV2 part cleanup by correcting the improper guard in clean_build so the build step can be cleaned. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3126 (commit 2d331e010), fixing PluginV2 part cleanup by correcting the guard in clean_build. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3126 fixed PluginV2 cleanup by removing the improper guard in clean_build, enabling parts to clean their build steps. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix resolving PluginV2 part cleanup failures caused by an improper guard in the clean_build method. Approved by reviewer, passed CI, and integrated into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix correcting an improper guard in the clean_build method, enabling PluginV2 parts to properly clean the build step. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3122 pluginhandler: make the build environment available to all steps | snapcraft | merged | Merged PR #3122 (commit f1f127136) refactoring pluginhandler so the build environment is available to all plugin steps, keeping build-environment limited to the build step. Fixes LP: #1876260. |