pluginhandler: allow cleaning the build step
Metadata
Current evaluation
Merged fix resolving PluginV2 part cleanup failures caused by an improper guard in the clean_build method. Approved by reviewer, passed CI, and integrated into the codebase.
Suggested action: —
No scores available.
Issue body
PluginV2 based parts were not able to clean due to the improper guard
set at the start of the clean_build method.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix resolving PluginV2 part cleanup failures caused by an improper guard in the clean_build method. Approved by reviewer, passed CI, and integrated into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix correcting an improper guard in the clean_build method, enabling PluginV2 parts to properly clean the build step. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Resolved PluginV2 build step cleaning failure by correcting an improper guard in the clean_build method. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3211 pluginhandler: fix stage-snaps for v2 plugins | snapcraft | merged | Merged fix for v2 plugin AttributeError caused by missing stage_snaps attribute. Updated logging to use part_install_dir and resolved prepare_build clearing the install directory. Approved and passed CI. | |
| #398 Support cleaning build step. | snapcraft | merged | Added clean_build method to the plugin API for selectively cleaning part-built files, with an initial Go plugin implementation. Approved by reviewers, passed CI checks, and merged into the base branch. | |
| #2327 pluginhandler: remove prepare, build and install scriptlets | snapcraft | merged | Merged removal of deprecated prepare, build, and install scriptlets from pluginhandler, replaced by override-step-name syntax. Backwards compatibility maintained via integration tests. Approved and passed CI. | |
| #3122 pluginhandler: make the build environment available to all steps | snapcraft | merged | Merged. Reviewer feedback refined scoping: build environment is now available across all plugin steps. SNAPCRAFT_STAGE stays global, build-environment stays on the build step. Changes affect 10 files. | |
| #2450 pluginhandler: handle removal of inconsistent files | snapcraft | merged | Merged a fix that prevents crashes during part cleanup when manually removed files are encountered. The system now safely ignores missing files and issues a warning instead. Approved by reviewers and passed CI checks. | |
| #3077 pluginhandler: skip plugin clean_pull for PluginV2 | snapcraft | merged | Merged. Updated unit tests to skip plugin clean_pull for PluginV2 as the method no longer exists, fixing SNAPCRAFT-1JS. |