← Back to issue list

cmake v2 plugin: configure with $SNAPCRAFT_PART_SRC

View original Github issue

Metadata

Project
snapcraft
Number
#3123
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in 6c6644476: the cmake v2 plugin now configures with $SNAPCRAFT_PART_SRC, preventing errors in projects that require separate source and build directories.

Resolution: closed resolved

Reason: PR #3123 was merged as commit 6c6644476, updating CMake configuration to use $SNAPCRAFT_PART_SRC and avoid in-source build errors.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This avoids errors on projects that check that the source directory does not match the build directory. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in 6c6644476: the cmake v2 plugin now configures with $SNAPCRAFT_PART_SRC, preventing errors in projects that require separate source and build directories.
stealth/space-bunny-alpha — closed resolved Merged #3123 (commit 6c6644476): the cmake v2 plugin now configures using $SNAPCRAFT_PART_SRC, avoiding errors in projects that require distinct source and build directories.
qwen/qwen3.6-35b-a3b — — Merged a fix updating the cmake v2 plugin to configure via $SNAPCRAFT_PART_SRC. This resolves build failures for projects verifying distinct source and build directories. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a cmake v2 plugin update to configure builds using $SNAPCRAFT_PART_SRC. This resolves failures in projects that require separate source and build directories.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3154 cmake v2 plugin: take source-subdir into account snapcraft merged Merged as 2a58a4e5c, updating the CMake v2 plugin to honor source-subdir by using SNAPCRAFT_PART_SOURCE_WORK for pull and build work directories.
84%
#1825797 cmake: Shouldn't use sourcedir for building snapcraft (launchpad) open CMake builds still read from SNAPCRAFT_PART_SRC, preventing patches to a build-tree copy before snapcraftctl build; current craft-parts behavior needs maintainer triage.
76%