← Back to issue list

cmake v2 plugin: configure with $SNAPCRAFT_PART_SRC

View original Github issue

Metadata

Project
snapcraft
Number
#3123
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged a fix updating the cmake v2 plugin to configure via $SNAPCRAFT_PART_SRC. This resolves build failures for projects verifying distinct source and build directories. Approved by one reviewer and passed CI checks.

Suggested action: —

No scores available.

Issue body

This avoids errors on projects that check that the source directory does not match the build directory. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a fix updating the cmake v2 plugin to configure via $SNAPCRAFT_PART_SRC. This resolves build failures for projects verifying distinct source and build directories. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a cmake v2 plugin update to configure builds using $SNAPCRAFT_PART_SRC. This resolves failures in projects that require separate source and build directories.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to cmake v2 plugin configuring builds via $SNAPCRAFT_PART_SRC. Resolves build failures in projects validating source and build directory paths. Approved and merged by maintainer sergiusens.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3154 cmake v2 plugin: take source-subdir into account snapcraft merged Merged. Updates cmake v2 plugin to use SNAPCRAFT_PART_SOURCE_WORK instead of SNAPCRAFT_PART_SOURCE for pull and build steps, fixing source subdirectory handling. Approved, passed CI, and modified 10 files (+55/-7).
86%
#2399 cmake plugin: use build snaps to search paths snapcraft merged Merged. Updated the cmake plugin to use build snaps for path searching. Approved by a reviewer with 96.29% diff coverage across two files (+155/-13 lines).
77%
#1825797 cmake: Shouldn't use sourcedir for building snapcraft (launchpad) open Request for cmake plugin to use out-of-source builds (build in SNAPCRAFT_PART_BUILD instead of SNAPCRAFT_PART_SRC). 2689 days old, no labels, no comments, no maintainer interaction. The current craft-parts cmake plugin already implements out-of-source builds via get_out_of_source_build() returning True.
75%
#3161 npm v2 plugin: always include $SNAPCRAFT_PART_INSTALL/bin in $PATH snapcraft merged Merged. Resolves npm v2 plugin build failures by always including $SNAPCRAFT_PART_INSTALL/bin in $PATH. Approved by reviewer, passed CI, and merged with a minimal 5-line change across two files.
74%
#2122 many: introduce variables for part src and build snapcraft merged Merged following approval. Introduces new environment variables and replacements for part src and build directories, resolving LP #1763028. Consolidates SNAPCRAFT_* environment handling into a single location. Approved by one reviewer with passing CI checks.
72%
#841 Replace SNAPCRAFT_PART_INSTALL in the part attributes. snapcraft merged Merged after dual reviewer approval. Replaced SNAPCRAFT_PART_INSTALL references across seven files with a 70-line update. Reviewers suggested adding cmake integration tests, but the change was merged without them.
71%
#1601 snapcraft.yaml: don't re-use build dir snapcraft merged Merged a fix for a source-build directory clash in snapcraft.yaml. The build directory was renamed to apt-build to avoid scriptlet conflicts. Approved by reviewers and passed CI, resolving the failure.
70%
#3217 cmake v2 plugin: add stage to CMAKE_PREFIX_PATH snapcraft merged Merged changes to the cmake v2 plugin that add a stage to CMAKE_PREFIX_PATH, fixing core18 to core20 snap porting. Unit tests were updated to pytest. Approved and passed CI.
70%