← Back to issue list

cmake v2 plugin: take source-subdir into account

View original Github issue

Metadata

Project
snapcraft
Number
#3154
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 2a58a4e5c, updating the CMake v2 plugin to honor source-subdir by using SNAPCRAFT_PART_SOURCE_WORK for pull and build work directories.

Resolution: closed resolved

Reason: PR #3154 was approved and merged as commit 2a58a4e5c. The change fixed source-subdir handling by using separate pull/build work-directory variables.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Setup 2 _WORK variables, for the pull and build step, use SNAPCRAFT_PART_SOURCE_WORK from get_build_commands instead of SNAPCRAFT_PART_SOURCE. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 2a58a4e5c, updating the CMake v2 plugin to honor source-subdir by using SNAPCRAFT_PART_SOURCE_WORK for pull and build work directories.
stealth/space-bunny-alpha — closed resolved Merged PR #3154 (commit 2a58a4e5c), making the cmake v2 plugin respect source-subdir during pull and build via SNAPCRAFT_PART_SOURCE_WORK.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#3154 via 2a58a4e5c, updating the CMake v2 plugin to honor the configured source subdirectory in pull and build steps.
qwen/qwen3.6-35b-a3b — — Merged. Updates cmake v2 plugin to use SNAPCRAFT_PART_SOURCE_WORK instead of SNAPCRAFT_PART_SOURCE for pull and build steps, fixing source subdirectory handling. Approved, passed CI, and modified 10 files (+55/-7).
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated the cmake v2 plugin to use SNAPCRAFT_PART_SOURCE_WORK instead of SNAPCRAFT_PART_SOURCE for pull and build steps, correctly accounting for source subdirectories.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3123 cmake v2 plugin: configure with $SNAPCRAFT_PART_SRC snapcraft merged Merged in 6c6644476: the cmake v2 plugin now configures with $SNAPCRAFT_PART_SRC, preventing errors in projects that require separate source and build directories.
84%
#94 Support the source-subdir keyword for parts snapcraft merged Merged snapcraft#94 via 9fe120945 (implementation 8741af4a3), adding source-subdir support while preserving source trees and delegating build-subdirectory selection to plugins.
77%
#1825797 cmake: Shouldn't use sourcedir for building snapcraft (launchpad) open CMake builds still read from SNAPCRAFT_PART_SRC, preventing patches to a build-tree copy before snapcraftctl build; current craft-parts behavior needs maintainer triage.
74%