plugin handler: debug build commands if developer debug enabled
Metadata
Current evaluation
Closed unmerged as superseded by snapcraft#3139, which merged isolated PluginV2 command execution and clearer error reporting in commit 389c180ea.
Resolution: closed superseded
Reason: The maintainer comment states that #3131 was no longer needed because #3139 addressed the underlying command isolation and error-reporting behavior. PR #3139 is recorded as merged in commit 389c180ea, and #3131 was closed without being merged.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Include `set -x` in build script if user enables developer debug.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as superseded by snapcraft#3139, which merged isolated PluginV2 command execution and clearer error reporting in commit 389c180ea. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; #3139 (commit 389c180ea) superseded developer-debug set -x by isolating PluginV2 commands and improving error reporting. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as superseded by #3139, which ran PluginV2 commands independently and improved build-step error handling. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged: #3139 superseded this change by isolating PluginV2 commands and improving build error reporting. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged: developer-debug tracing was superseded by #3139, which ran PluginV2 commands independently and improved error reporting. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged: debug tracing for build commands was superseded by #3139, which ran PluginV2 commands independently and improved error reporting. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The proposed debug flag addition was superseded by #3139, which addressed the same requirement. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed as unnecessary. Maintainer noted the debug build command logging became redundant after PR #3139 addressed the underlying requirement, superseding this pull request. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#3139
(confidence 99%)
The closing comment explicitly identifies #3139 as making the proposed tracing change unnecessary.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3139 pluginhandler: run plugin commands in isolation | snapcraft | merged | Merged in snapcraft#3139 (389c180ea), running PluginV2 commands independently for clearer errors and PluginV1-equivalent execution exceptions; fixes SNAPCRAFT-1NQ. | |
| #3317 plugin handler: properly handle snapcraftctl errors | snapcraft | merged | Merged PR #3317 in commit 9c622ecda, making snapcraftctl exit nonzero on build/pull failures and stop override scripts after parent operation errors. | |
| #1998 pluginhandler: add {pre,post}-build scriptlets | snapcraft | closed | Closed unmerged; its pre-/post-build rename was superseded by #2002 (bbca282fa), which introduced snapcraftctl and override-build. |