lifecycle: use snap from path to --check-skeleton
Metadata
Current evaluation
Merged PR #3137 in commit 2515447f5, changing lifecycle skeleton checks to invoke the host snap command with --check-skeleton.
Resolution: closed resolved
Reason: PR #3137 was approved and merged as commit 2515447f5, implementing the snapd team's recommendation to use the host snap executable for skeleton validation.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The snapd team has made the recommendation for Snapcraft to just use the
snap command from the host.
LP: #1862242
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3137 in commit 2515447f5, changing lifecycle skeleton checks to invoke the host snap command with --check-skeleton. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3137 in commit 2515447f5, switching lifecycle skeleton checks to the host snap command from PATH per snapd's recommendation. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3137 updated lifecycle to run skeleton checks with the host snap executable, per LP: #1862242. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a change to replace the --check-skeleton flag with the host snap command for lifecycle operations, following the snapd team recommendation. Approved by one reviewer, modifying one file with 15 additions and 21 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change to replace the --check-skeleton flag with the host snap command in the lifecycle module, aligning with snapd team recommendations. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1862242
(confidence 95%)
The PR body links this implementation to Launchpad bug #1862242 and its snapd-team recommendation.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3743 pack: check skeleton | snapcraft | merged | Merged #3743, adding an explicit snap pack --check-skeleton validation step until snap pack performs skeleton checks natively. | |
| #1891 lifecycle: use in-snap mksquashfs if running from snap | snapcraft | merged | PR #1891 merged (commit f3d870e4e) so lifecycle uses the mksquashfs bundled inside the snapcraft snap when running as a snap, instead of relying on $PATH. Later replaced by `snap pack` in #3173. |