lifecycle: use snap from path to --check-skeleton
Metadata
Current evaluation
Merged a change to replace the --check-skeleton flag with the host snap command for lifecycle operations, following the snapd team recommendation. Approved by one reviewer, modifying one file with 15 additions and 21 deletions.
Suggested action: —
No scores available.
Issue body
The snapd team has made the recommendation for Snapcraft to just use the
snap command from the host.
LP: #1862242
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a change to replace the --check-skeleton flag with the host snap command for lifecycle operations, following the snapd team recommendation. Approved by one reviewer, modifying one file with 15 additions and 21 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change to replace the --check-skeleton flag with the host snap command in the lifecycle module, aligning with snapd team recommendations. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to the lifecycle module, replacing the --check-skeleton flag with the host snap command per snapd team recommendations and LP: #1862242. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3743 pack: check skeleton | snapcraft | merged | Merged into main. Adds the --check-skeleton flag to snap pack to validate skeleton directories. Approved by a reviewer, passed CI, and modified two files. Codecov noted a minor coverage decrease, but the change was integrated. | |
| #1891 lifecycle: use in-snap mksquashfs if running from snap | snapcraft | merged | Merged lifecycle changes to use the snap-bundled mksquashfs binary instead of relying on the system PATH when running as a snap. Approved by reviewer and passed CI checks. | |
| #4589 feat(lifecycle): add deprecated snap command | snapcraft | merged | Merged after two approvals and passing CI. Adds a deprecated snap command to the lifecycle module. Reviewers requested fixture simplifications and rebasing, which were implemented before final merge. |