pack: check skeleton
Metadata
Current evaluation
Merged #3743, adding an explicit snap pack --check-skeleton validation step until snap pack performs skeleton checks natively.
Resolution: closed resolved
Reason: PR #3743 was merged in commit 74d92c7b0. Implementation commit 7c927032d added the skeleton check and corresponding tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Run "snap pack --check-skeleton" until "snap pack" does it.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3743, adding an explicit snap pack --check-skeleton validation step until snap pack performs skeleton checks natively. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3743 merged into main; commit 7c927032d added --check-skeleton validation to snap pack. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Adds the --check-skeleton flag to snap pack to validate skeleton directories. Approved by a reviewer, passed CI, and modified two files. Codecov noted a minor coverage decrease, but the change was integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Introduces the --check-skeleton flag for snap pack as a temporary measure until the check becomes default. Codecov reported a 0.11% overall coverage decrease with 90% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1950465 snapcraft does not seem to call `snap pack --check-skeleton` to validate that snap has correct things | snapcraft (launchpad) | closed | Snapcraft now runs snap pack --check-skeleton during packing, catching invalid plug and slot names before installation. Implemented by merged PR #3743 (commit 7c927032d). | |
| #3137 lifecycle: use snap from path to --check-skeleton | snapcraft | merged | Merged PR #3137 in commit 2515447f5, changing lifecycle skeleton checks to invoke the host snap command with --check-skeleton. | |
| #3173 cli: use snap pack instead of mksquashfs | snapcraft | merged | Merged in snapcore/snapcraft#3173 (63bc74cba), replacing direct mksquashfs packaging with snap pack and removing the obsolete skeleton-check flow. |