npm v2 plugin: always include $SNAPCRAFT_PART_INSTALL/bin in $PATH
Metadata
Current evaluation
Merged. Resolves npm v2 plugin build failures by always including $SNAPCRAFT_PART_INSTALL/bin in $PATH. Approved by reviewer, passed CI, and merged with a minimal 5-line change across two files.
Suggested action: —
No scores available.
Issue body
That's where we are unpacking node to anyways, always include it.
If node is already in ${SNAPCRAFT_PART_INSTALL}/bin, then the PATH
never gets updated, breaking the build.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Resolves npm v2 plugin build failures by always including $SNAPCRAFT_PART_INSTALL/bin in $PATH. Approved by reviewer, passed CI, and merged with a minimal 5-line change across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for npm v2 plugin to always include $SNAPCRAFT_PART_INSTALL/bin in $PATH. This resolves build failures when node is already in that directory by ensuring the PATH is correctly updated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. The npm v2 plugin now always includes $SNAPCRAFT_PART_INSTALL/bin in $PATH to prevent build failures when node is already present in that directory, ensuring correct path resolution. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #200 plugins: npm | craft-parts | merged | Merged the npm plugin port from snapcraft to craft-parts. Added an npm-include-node flag defaulting to false to optionally download Node.js. Approved by reviewer and passed CI. | |
| #3123 cmake v2 plugin: configure with $SNAPCRAFT_PART_SRC | snapcraft | merged | Merged a fix updating the cmake v2 plugin to configure via $SNAPCRAFT_PART_SRC. This resolves build failures for projects verifying distinct source and build directories. Approved by one reviewer and passed CI checks. |