← Back to issue list

plugins: npm

View original Github issue

Metadata

Project
craft-parts
Number
#200
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #200 as b9881154 (feature commit 343d5c6b), porting Snapcraft’s npm plugin and adding npm-include-node with a false default.

Resolution: closed resolved

Reason: PR #200 was approved and merged, adding the npm plugin from Snapcraft. Commit 343d5c6b is the feature commit, and b9881154 records its merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Port the `npm` plugin from [`snapcraft`](https://github.com/snapcore/snapcraft/blob/main/snapcraft/plugins/v2/npm.py) to `craft-parts`. CRAFT-957

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #200 as b9881154 (feature commit 343d5c6b), porting Snapcraft’s npm plugin and adding npm-include-node with a false default.
stealth/space-bunny-alpha — closed resolved Merged the npm plugin port from snapcraft into craft-parts in PR #200, with npm-include-node defaulting to false.
stealth/space-bunny-alpha — closed resolved Merged #200 (343d5c6b), porting the npm plugin from snapcraft to craft-parts and adding npm-include-node (default false) to optionally include Node.js.
qwen/qwen3.6-35b-a3b — — Merged the npm plugin port from snapcraft to craft-parts. Added an npm-include-node flag defaulting to false to optionally download Node.js. Approved by reviewer and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged the npm plugin port from snapcraft to craft-parts. Adds the npm-include-node flag, defaulting to false, to optionally download and bundle Node.js. Addresses CRAFT-957.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#936 nodejs plugin: install during pull to support npm run snapcraft merged Merged in snapcraft#936 (commit 0497daaac), installing Node.js dependencies during pull so npm run commands can access them.
71%
#3161 npm v2 plugin: always include $SNAPCRAFT_PART_INSTALL/bin in $PATH snapcraft merged Merged PR #3161 (71cebabd8) always adds ${SNAPCRAFT_PART_INSTALL}/bin to PATH, preventing npm v2 builds from failing when node is already present there.
70%