← Back to issue list

tests: remove scenario usage from lifecycle order

View original Github issue

Metadata

Project
snapcraft
Number
#3162
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 58c66b7a7, dropping testscenarios usage from the lifecycle-order unit tests as groundwork for the move to pytest, which landed separately in #3167.

Resolution: closed resolved

Reason: The PR was merged (approved, 1 reviewer, +777/-370 in 1 file) as commit 58c66b7a7 "tests: remove scenario usage from lifecycle order (#3162)". It removed the testscenarios dependency from tests/unit/services/test_lifecycle.py, a preparatory step for the pytest migration completed in #3167 (commit 788475f62).

Evaluated by: mr-cal-bot

No scores available.

Issue body

This is to ease the transition to pytest. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 58c66b7a7, dropping testscenarios usage from the lifecycle-order unit tests as groundwork for the move to pytest, which landed separately in #3167.
stealth/space-bunny-alpha — closed resolved Merged as commit 58c66b7a7, removing scenario usage from lifecycle-order tests to ease the pytest transition.
stealth/space-bunny-alpha — closed resolved Merged PR #3162 as commit 58c66b7a7, removing scenario usage from lifecycle-order tests to ease the transition to pytest.
qwen/qwen3.6-35b-a3b — — Merged following approval and passing CI. Removes scenario usage from lifecycle order tests to facilitate the pytest transition. Modified one file with 777 additions and 370 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged a maintainer pull request removing scenario usage from lifecycle order tests to facilitate the transition to pytest. The change was integrated without comments.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#3167 (confidence 82%)

    Follow-up PR that migrated the unit tests from testscenarios to pytest, the transition #3162 explicitly set out to ease; merged as 788475f62.

Related issues

Issue Project State Summary Similarity
#3167 unit tests: move to pytest snapcraft merged Merged PR #3167 in commit 788475f62, migrating unit tests from testscenarios to pytest, adding fixtures and pytest-cov, and retaining unittest for integration tests.
75%
#2163 tests: add lifecycle ordering tests snapcraft merged Merged in #2163 via commit efebd07e9, adding lifecycle-ordering tests and refactoring lifecycle tests into a dedicated package; Codecov reported 100% diff coverage.
71%