plugins: fix loading of catkin-tools
Metadata
Current evaluation
Merged a one-line correction changing catkin_tools to catkin-tools in the plugin loader, resolving package loading failures. Approved, passed CI, and addresses LP #1882996.
Suggested action: —
No scores available.
Issue body
Typo "catkin_tools" should be "catkin-tools".
We need a spread test for this plugin.
LP: #1882996
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line correction changing catkin_tools to catkin-tools in the plugin loader, resolving package loading failures. Approved, passed CI, and addresses LP #1882996. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the catkin-tools plugin loading failure by correcting a typo in the package name from catkin_tools to catkin-tools. Resolves Launchpad bug #1882996. Codecov reported a minor coverage decrease upon merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a typo fix that corrected the catkin-tools plugin package name from catkin_tools to catkin-tools, resolving a plugin loading failure. The change addresses Launchpad bug #1882996 and was integrated into the main branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1779 catkin-tools plugin: use stage-packages | snapcraft | merged | Merged a fix switching the catkin-tools plugin from build-packages to stage-packages, resolving clean system failures. Added an integration test. Approved by two reviewers and passed CI. | |
| #1593 catkin tools plugin: add catkin tools support. | snapcraft | merged | Merged a new catkin tools plugin replacing catkin_make. After review, conflict resolution, and adding a beta warning, the changes were approved. Brief testing infrastructure delays preceded successful integration. | |
| #5729 docs: migrate 'the catkin-tools plugin' | snapcraft | merged | Merged documentation update migrating the catkin-tools plugin. Approved by two reviewers with all CI checks passing. Changes span three files, adding 87 lines and removing 5. | |
| #1526 catkin plugin: don't assume catkin is in underlay | snapcraft | merged | Merged fix updating the catkin plugin to use its isolated installation instead of assuming catkin exists in the underlay. Resolves Launchpad bug #1696014. Includes reviewer-requested test naming updates. Approved and merged. | |
| #1001 plugins: update catkin plugin to use get_pull_properties() | snapcraft | merged | Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines. | |
| #2546 [legacy] catkin plugin: ensure cxxflags are consistent | snapcraft | merged | Merged fix for the legacy catkin plugin ensuring deterministic include path ordering. Resolves unnecessary rebuilds from non-deterministic cxxflags. Approved, passed CI, and merged. | |
| #2545 catkin plugin: use build-packages for compilers | snapcraft | merged | Merged updates to the Catkin plugin that specify compilers as build-packages instead of isolating them. This resolves a rebuild failure and aligns with current base requirements. Approved by one reviewer and passed CI. |