← Back to issue list

plugins: fix loading of catkin-tools

View original Github issue

Metadata

Project
snapcraft
Number
#3168
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3168 as commit 9c3f8c519, correcting catkin_tools to catkin-tools so the catkin-tools plugin loads correctly.

Resolution: closed resolved

Reason: PR #3168 was merged into master as commit 9c3f8c519. Its one-line correction changed the plugin name from catkin_tools to catkin-tools.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Typo "catkin_tools" should be "catkin-tools". We need a spread test for this plugin. LP: #1882996 Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3168 as commit 9c3f8c519, correcting catkin_tools to catkin-tools so the catkin-tools plugin loads correctly.
stealth/space-bunny-alpha — closed resolved Merged #3168 in commit 9c3f8c519, correcting the catkin-tools plugin name from catkin_tools so it loads correctly.
stealth/space-bunny-alpha — closed resolved Merged PR #3168 (commit 9c3f8c519) into master: fixed the plugin's declared name typo ("catkin_tools" → "catkin-tools"), so the catkin-tools plugin is loaded correctly.
stealth/space-bunny-alpha — closed resolved Merged #3168, fixing catkin-tools plugin loading by correcting the underscore typo; landed in commit 9c3f8c519.
stealth/space-bunny-alpha — closed resolved Merged PR #3168 corrected catkin_tools to catkin-tools in the plugin loader, fixing catkin-tools loading.
qwen/qwen3.6-35b-a3b — — Merged a one-line correction changing catkin_tools to catkin-tools in the plugin loader, resolving package loading failures. Approved, passed CI, and addresses LP #1882996.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for the catkin-tools plugin loading failure by correcting a typo in the package name from catkin_tools to catkin-tools. Resolves Launchpad bug #1882996. Codecov reported a minor coverage decrease upon merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1593 catkin tools plugin: add catkin tools support. snapcraft merged Merged PR #1593 (commit 7e31fa0dd), adding a beta catkin-tools plugin that uses catkin tools for builds while retaining catkin_make behavior.
79%
#5729 docs: migrate 'the catkin-tools plugin' snapcraft merged Merged PR #5729, migrating the Catkin Tools plugin reference to the updated documentation format in commit 903f2737f.
74%
#3282 v2 plugins: add catkin-tools plugin snapcraft merged Merged as commit 8303c300e, adding a v2 catkin-tools plugin that reuses shared ROS functionality from the Catkin and Colcon plugins.
70%