← Back to issue list

catkin tools plugin: add catkin tools support.

View original Github issue

Metadata

Project
snapcraft
Number
#1593
Type
pull request
State
merged
Author
cratliff
Labels
Created
Updated
Closed

Current evaluation

Merged a new catkin tools plugin replacing catkin_make. After review, conflict resolution, and adding a beta warning, the changes were approved. Brief testing infrastructure delays preceded successful integration.

Suggested action:

No scores available.

Issue body

Adding suppot for catkin tools. Initially the only difference is the build is being performed by catkin tools instead of catkin_make, while all other function inherits from catkin_make. LP: #1693380 - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a new catkin tools plugin replacing catkin_make. After review, conflict resolution, and adding a beta warning, the changes were approved. Brief testing infrastructure delays preceded successful integration.
qwen3.6-35b-a3b-mtp-q6 Merged PR adding a standalone catkin_tools plugin to snapcraft. Maintainers approved separating it from the original catkin plugin due to API stability and feature divergence. Author added a beta warning, resolved conflicts, and confirmed testing before merge.
qwen3.6-35b-a3b-mtp-q6 Merged a new catkin_tools plugin inheriting from catkin_make. Marked beta due to upstream beta status and potential API changes. Content sharing support deferred. Conflict resolved and beta warning added before merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3168 plugins: fix loading of catkin-tools snapcraft merged Merged a one-line correction changing catkin_tools to catkin-tools in the plugin loader, resolving package loading failures. Approved, passed CI, and addresses LP #1882996.
78%
#3282 v2 plugins: add catkin-tools plugin snapcraft merged Merged. Introduces a catkin-tools plugin using the v2 plugin API, reusing shared ROS functionality from existing Catkin and Colcon plugins. Passed static and unit tests, approved by two reviewers, and successfully integrated.
77%
#1779 catkin-tools plugin: use stage-packages snapcraft merged Merged a fix switching the catkin-tools plugin from build-packages to stage-packages, resolving clean system failures. Added an integration test. Approved by two reviewers and passed CI.
76%
#152 Catkin plugin: Add support for ROS tools. snapcraft merged Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled.
76%
#175 Catkin plugin: Refactor build. snapcraft merged Merged after addressing reviewer feedback on error handling and testing strategy. The update refactored the Catkin plugin build process, simplified build logic, extracted dependency resolution, added a source-space keyword, and achieved 100% unit test coverage.
73%
#5729 docs: migrate 'the catkin-tools plugin' snapcraft merged Merged documentation update migrating the catkin-tools plugin. Approved by two reviewers with all CI checks passing. Changes span three files, adding 87 lines and removing 5.
72%
#3268 v2 plugins: add catkin plugin snapcraft merged Merged after passing review and CI checks. Introduced a new Catkin plugin using the v2 plugin API and refactored shared code from the Colcon plugin. Additional spread tests were added to verify all plugin options.
70%