project loader: refactor errors to conform to SnapcraftException
Metadata
Current evaluation
PR #3234 was closed unmerged after its author reported omitted files; a maintainer later requested reopening once unblocked.
Resolution: closed stale
Reason: The author acknowledged on 2020-07-30 that the diff was incomplete, and no resolving commit or replacement PR was identified. On 2020-09-28, a maintainer asked for it to be reopened when unblocked.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Refactor errors found in snapcraft.internal.project_loader and
snapcraft.internal.project_loader.inspection.
- Drop ExtensionMissingDocumentationError, replacing with
a RuntimeError as it should never occur and be exposed to
the user.
- Rebase all exceptions on SnapcraftException.
- Introduce test_errors for project loader, removing whatever
tests existed in tests/unit/test_errors.
- Prefix all exception names with "Snapcraft".
- Minor wording/formatting changes for certain exceptions
to better conform to SnapcraftException usage.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #3234 was closed unmerged after its author reported omitted files; a maintainer later requested reopening once unblocked. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged after the author reported missing changed files; a maintainer later asked to reopen it once unblocked. No resolving commit was found. | |
| stealth/space-bunny-alpha | — | closed stale | Project-loader error refactor was closed unmerged after missing files; a maintainer later asked that it be reopened once unblocked. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The author omitted changed files and noted a follow-up. The reviewer requested re-opening when unblocked. Prolonged inactivity resulted in the pull request being abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging after required files were omitted. A maintainer requested re-opening once the changes are ready. The pull request remains unmerged pending author action. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1504 project loader: refactor into package | snapcraft | merged | Merged in snapcraft#1504 via commit 80630158d, creating a project-loader package and moving PartsConfig, schema validation, and loader errors into it. | |
| #2734 SnapcraftError refactoring | snapcraft | merged | SnapcraftError refactoring was merged in canonical/snapcraft#2734 after maintainer approval, updating four files (+279/-26). |