← Back to issue list

SnapcraftError refactoring

View original Github issue

Metadata

Project
snapcraft
Number
#2734
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Refactored SnapcraftError across four files, adding 279 lines and removing 26. Approved by one reviewer and merged into the codebase.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Refactored SnapcraftError across four files, adding 279 lines and removing 26. Approved by one reviewer and merged into the codebase.
qwen3.6-35b-a3b-mtp-q6 Merged maintainer cjp256's refactoring of the SnapcraftError class. Changes were integrated directly into the codebase without additional review comments.
qwen3.6-35b-a3b-mtp-q6 Merged maintainer cjp256's refactoring of the SnapcraftError class. Changes were integrated directly into the codebase without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1407 recording: record the original snapcraft.yaml snapcraft merged Merged to record the original snapcraft.yaml. Approved by one reviewer, modified 6 files with 91 additions and 31 deletions. Author noted the change requires PR #1406.
74%
#58 changes to snapcraft.yaml, and version, for 0.2.0 charmcraft merged Merged following single reviewer approval. Updated snapcraft.yaml and bumped project version to 0.2.0 across two files, adding 107 lines and removing 9.
73%
#86 meta: use snapcraft's versioning scheme starbase merged Merged after two approvals and passing CI. Updates the versioning scheme to match snapcraft's using setuptools-scm, adding 78 lines across two files with zero coverage impact.
72%
#2160 many: refactor snapcraft.yaml loading out of load_config snapcraft merged Merged a refactor separating raw snapcraft.yaml loading from validated processing within load_config. Approved by reviewer, passed CI checks, and integrated into master with 95.54% diff coverage.
72%
#204 Update snapcraft.yaml charmcraft merged Merged updates to snapcraft.yaml by markshuttle. Applied text changes for snapcraft.io and snap users, approved by two reviewers with zero unresolved comments. Diff added 18 lines and removed 14 across one file.
72%
#1499 repo: make errors based on SnapcraftError snapcraft merged Merged a fix preventing repo-based errors from triggering tracebacks outside debug mode by inheriting from SnapcraftError. Approved by two reviewers, passed CI, and resolves an oversight from PR #1436.
72%
#2283 snapcraft snap: refactor override-build into a script snapcraft merged Merged refactoring that extracts override-build into a standalone script to reduce snapcraft.yaml duplication and support internal vendoring. Approved by reviewer, passed CI, and modified two files.
72%
#2109 sources: clean up IncompatibleOptionsError snapcraft merged Merged refactoring splitting IncompatibleOptionsError into SnapcraftSourceIncompatibleOptionsError and SnapcraftSourceInvalidOptionError. Updated tests to use new classes and assert properties. Approved and merged after passing CI.
71%
#307 Document Snapcraft's wrapper script snapcraft merged Merged documentation update describing Snapcraft's wrapper script. Author addressed review feedback, adding 25 lines to one file and closing Launchpad bug #1543581.
71%
#2752 errors: migrate handful of errors to SnapcraftException snapcraft merged Merged. Migrates multiple error classes to SnapcraftException, adds a SnapcraftReportableException helper, simplifies error messages, and updates tests. Approved by a maintainer and passed CI checks.
71%